Fix gas estimation for roflmarket.InstanceTopUp#673
Merged
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
peternose
approved these changes
Jan 9, 2026
peternose
reviewed
Jan 9, 2026
ptrus
force-pushed
the
ptrus/feature/gas-estimate-instancetopup
branch
from
d437c83 to
79d37d6
Compare
ptrus
force-pushed
the
ptrus/feature/gas-estimate-instancetopup
branch
from
79d37d6 to
91aa647
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #611
The runtime's gas estimation for
roflmarket.InstanceTopUpunderestimates the required gas because the handler returns early in simulation mode: https://github.com/oasisprotocol/oasis-sdk/blob/18fa39523a241cb15476b0184bc2e49a871b10e7/runtime-sdk/modules/rofl-market/src/lib.rs#L454-L456skipping storage operations like instance updates and payment transfers. The standard 20% buffer wasn't sufficient to always cover this gap. This adds a higher gas buffer (50%) specifically for this method.
This was the simplest fix.
Possible alternative: