Merge pull request #1443 from oasisprotocol/csillag/hide-nan

csillag · web-flow · commit f9b0642c59ec · 2024-06-05T15:30:21.000+02:00
Avoid showing "NaN%" in the charts when there is no prev data
diff --git a/.changelog/1443.trivial.md b/.changelog/1443.trivial.md
@@ -0,0 +1 @@
+Avoid showing "NaN%" in the charts when there is no prev data
diff --git a/src/app/components/PercentageGain/index.tsx b/src/app/components/PercentageGain/index.tsx
@@ -13,6 +13,9 @@ interface PercentageGainProps {
  * Negative percentage shows red box with down arrow.
  */
 export const PercentageGain: FC<PercentageGainProps> = ({ earliestValue, latestValue }) => {
+  // If the previous data was zero, we can't divide with it, it would just get us infinity or Nan...
+  if (earliestValue === 0) return
+
   const ratio = (latestValue - earliestValue) / earliestValue
 
   return (

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Avoid showing "NaN%" in the charts when there is no prev data`