Solve warning about missing dialog title#2168
Merged
Merged
Conversation
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/solve-warning-about-missing-dialog-title
branch
from
d2349d4 to
e0239ce
Compare
csillag
force-pushed
the
csillag/solve-warning-about-missing-dialog-title
branch
from
e0239ce to
7e8957d
Compare
Contributor
Author
|
See also oasisprotocol/ui-library#62 for some more cleanup related to the layer picker |
csillag
force-pushed
the
csillag/solve-warning-about-missing-dialog-title
branch
from
7e8957d to
266e7d1
Compare
Contributor
Author
|
This PR now also includes a bump of ui-library, to use the latest version that also has the fix for the warning about the missing forwardRef, also triggered by the layer picker. |
buberdds
approved these changes
Sep 4, 2025
n the layout picker, we are using a Drawer component, which is using Radix's Dialog under the hood. On the browser console, there was a message: > `DialogContent` requires a `DialogTitle` > for the component to be accessible for screen reader users. etc. This change fixes that, by wrapping the already existing app logo with the required DrawerTitle tag.
csillag
force-pushed
the
csillag/solve-warning-about-missing-dialog-title
branch
from
266e7d1 to
4900bb9
Compare
csillag
force-pushed
the
csillag/solve-warning-about-missing-dialog-title
branch
from
4900bb9 to
4e18ced
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the layout picker, we are using a Drawer component, which is using Radix's Dialog under the hood.
On the browser console, there was a message:
etc.
This change fixes that, by wrapping the already existing app logo with the required
DrawerTitletag.