Replace MUI Tooltip with Oasis UI Library component #2301
Merged
Conversation
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/uil-tooltip-3
branch
from
f61ad36 to
79ffc22
Compare
buberdds
force-pushed
the
mz/uil-tooltip-3
branch
3 times, most recently
from
24d1267 to
94c1402
Compare
kaja-osojnik
reviewed
Nov 4, 2025
kaja-osojnik
left a comment
kaja-osojnik
left a comment
Contributor
There was a problem hiding this comment.
Is this tooltip supposed to wrap here? On master on single line:
branch:
vs mater:
buberdds
force-pushed
the
mz/uil-tooltip-3
branch
from
94c1402 to
dd3a188
Compare
buberdds
force-pushed
the
mz/uil-tooltip-3
branch
from
dd3a188 to
0d918e4
Compare
Contributor
Author
For now I have increased slightly max width in this one place to avoid this. Switching back to mono will prob resolve issues like this as oasis1 addr width will be more stable (and we can set proper max width in UI Lib). |
kaja-osojnik
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooltips with disable prop
Needs oasisprotocol/ui-library#84
Consensus tx method icon (mobile enabled / desktop disabled)
https://pr-2301.oasis-explorer.pages.dev/mainnet/consensus/tx?page=2
vs https://explorer.dev.oasis.io/mainnet/consensus/tx?page=2
truncated value with MaybeWithTooltip (truncated enabled / original value disabled)
https://pr-2301.oasis-explorer.pages.dev/mainnet/consensus/tx/25ad10b1ca91abc5ec3d74fe20843015a52b33646dea299096ac0b3277324ea2
vs https://explorer.dev.oasis.io/mainnet/consensus/tx/25ad10b1ca91abc5ec3d74fe20843015a52b33646dea299096ac0b3277324ea2