Merge pull request #6465 from oasisprotocol/peternose/internal/bump-go-1.26.0

peternose · web-flow · commit 394625d4f397 · 2026-02-19T10:18:11.000+01:00
go: Bump Go to 1.26.0
diff --git a/.changelog/6465.internal.md b/.changelog/6465.internal.md
@@ -0,0 +1 @@
+go: Bump Go to 1.26.0
diff --git a/.github/workflows/ci-lint.yml b/.github/workflows/ci-lint.yml
@@ -46,7 +46,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v6
         with:
-          go-version: ">=1.25.5"
+          go-version: ">=1.26.0"
       - name: Set up Rust
         run: rustup show
       - name: Install dependencies
diff --git a/.github/workflows/ci-reproducibility.yml b/.github/workflows/ci-reproducibility.yml
@@ -16,7 +16,7 @@ on:
 env:
   CURL_CMD: curl --proto =https --tlsv1.2 --location --silent --show-error --fail
   GORELEASER_URL_PREFIX: https://github.com/goreleaser/goreleaser/releases/download/
-  GORELEASER_VERSION: 2.9.0
+  GORELEASER_VERSION: 2.13.3
   JEMALLOC_URL_PREFIX: https://github.com/jemalloc/jemalloc/releases/download/
   JEMALLOC_VERSION: 5.2.1
   JEMALLOC_CHECKSUM: 34330e5ce276099e2e8950d9335db5a875689a4c6a56751ef3b1d8c537f887f6
@@ -39,7 +39,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v6
         with:
-          go-version: ">=1.25.5"
+          go-version: ">=1.26.0"
       - name: Set up Rust
         working-directory: build${{ matrix.build_number }}
         run: rustup show
diff --git a/.github/workflows/release-dev.yml b/.github/workflows/release-dev.yml
@@ -13,7 +13,7 @@ on:
 env:
   CURL_CMD: curl --proto =https --tlsv1.2 --location --silent --show-error --fail
   GORELEASER_URL_PREFIX: https://github.com/goreleaser/goreleaser/releases/download/
-  GORELEASER_VERSION: 2.9.0
+  GORELEASER_VERSION: 2.13.3
   JEMALLOC_URL_PREFIX: https://github.com/jemalloc/jemalloc/releases/download/
   JEMALLOC_VERSION: 5.2.1
   JEMALLOC_CHECKSUM: 34330e5ce276099e2e8950d9335db5a875689a4c6a56751ef3b1d8c537f887f6
@@ -35,7 +35,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v6
         with:
-          go-version: ">=1.25.5"
+          go-version: ">=1.26.0"
       - name: Set up Rust
         run: rustup show
       - name: Install Oasis Node prerequisites
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -15,7 +15,7 @@ on:
 env:
   CURL_CMD: curl --proto =https --tlsv1.2 --location --silent --show-error --fail
   GORELEASER_URL_PREFIX: https://github.com/goreleaser/goreleaser/releases/download/
-  GORELEASER_VERSION: 2.9.0
+  GORELEASER_VERSION: 2.13.3
   JEMALLOC_URL_PREFIX: https://github.com/jemalloc/jemalloc/releases/download/
   JEMALLOC_VERSION: 5.2.1
   JEMALLOC_CHECKSUM: 34330e5ce276099e2e8950d9335db5a875689a4c6a56751ef3b1d8c537f887f6
@@ -38,7 +38,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v6
         with:
-          go-version: ">=1.25.5"
+          go-version: ">=1.26.0"
 
       - name: Set up Rust
         run: rustup show
diff --git a/docker/oasis-core-dev/Dockerfile b/docker/oasis-core-dev/Dockerfile
@@ -1,12 +1,12 @@
 FROM ubuntu:24.04
 
 # Package versions.
-ARG GO_VERSION=1.25.5
+ARG GO_VERSION=1.26.0
 ARG GO_NANCY_VERSION=1.0.33
 ARG GO_NANCY_CHECKSUM=a4bf5290d41b095c04f941ed5380674770c79d59735e33b1bd07a5cd5fbb135d
 ARG GO_PROTOC_VERSION=3.6.1
 ARG GO_PROTOC_GEN_GO_VERSION=1.21.0
-ARG GOLANGCILINT_VERSION=2.8.0
+ARG GOLANGCILINT_VERSION=2.10.1
 ARG GOCOVMERGE_VERSION=b5bfa59ec0adc420475f97f89b58045c721d761c
 ARG GOFUMPT_VERSION=v0.8.0
 ARG GOIMPORTS_VERSION=v0.36.0
diff --git a/docs/development-setup/prerequisites.md b/docs/development-setup/prerequisites.md
@@ -40,7 +40,7 @@ Core:
   ```
   <!-- markdownlint-enable line-length -->
 
-* [Go] (at least version 1.25.5).
+* [Go] (at least version 1.26.0).
 
   If your distribution provides a new-enough version of Go, just use that.
 
@@ -52,18 +52,18 @@ Core:
   * [ensure `$GOPATH/bin` is in your `PATH`](
     https://tip.golang.org/doc/code.html#GOPATH),
   * [install the desired version of Go](
-    https://golang.org/doc/install#extra_versions), e.g. 1.25.5, with:
+    https://golang.org/doc/install#extra_versions), e.g. 1.26.0, with:
 
     ```
-    go install golang.org/dl/go1.25.5@latest
-    go1.25.5 download
+    go install golang.org/dl/go1.26.0@latest
+    go1.26.0 download
     ```
 
   * instruct the build system to use this particular version of Go by setting
     the `OASIS_GO` environment variable in your `~/.bashrc`:
 
     ```
-    export OASIS_GO=go1.25.5
+    export OASIS_GO=go1.26.0
     ```
 
 * [Rust].
@@ -151,7 +151,7 @@ Core:
   ```
   curl -sSfL \
   https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh \
-   | sh -s -- -b $(${OASIS_GO:-go} env GOPATH)/bin v2.8.0
+   | sh -s -- -b $(${OASIS_GO:-go} env GOPATH)/bin v2.10.1
   ```
 
 * (**OPTIONAL**) [protoc-gen-go].
diff --git a/go/common/crypto/mrae/api/api.go b/go/common/crypto/mrae/api/api.go
@@ -90,10 +90,10 @@ func TestBoxIntegration(t *testing.T, impl Box, ctor func([]byte) (cipher.AEAD,
 	for i := range n {
 		n[i] = byte(i)
 	}
-	for i := range aad {
+	for i := range len(aad) {
 		aad[i] = byte(i + nonceSize)
 	}
-	for i := range msg {
+	for i := range len(msg) {
 		msg[i] = byte(i + nonceSize + len(aad))
 	}
 
diff --git a/go/common/grpc/errors_test.go b/go/common/grpc/errors_test.go
@@ -169,7 +169,7 @@ func TestErrorMapping(t *testing.T) {
 	require.NoError(err, "TempFile")
 	// Remove the file as we only need the name.
 	f.Close()
-	os.Remove(f.Name())
+	os.Remove(f.Name()) //nolint:gosec
 
 	cfg := &ServerConfig{
 		Path: f.Name(),
diff --git a/go/common/sgx/pcs/tcb.go b/go/common/sgx/pcs/tcb.go
@@ -457,7 +457,7 @@ func (tl *TCBLevel) matches(sgxCompSvn [16]int32, tdxCompSvn *[16]byte, pcesvn u
 	//    otherwise move to the next item on TCB Levels list.
 	for i, comp := range tl.TCB.SGXComponents {
 		// At least one SVN is lower, no match.
-		if sgxCompSvn[i] < comp.SVN {
+		if sgxCompSvn[i] < comp.SVN { //nolint:gosec
 			return false
 		}
 	}
diff --git a/go/common/version/version.go b/go/common/version/version.go
@@ -92,13 +92,10 @@ func FromString(s string) (Version, error) {
 	// Take at most four components: major.minor.patch.remainder.
 	split := strings.SplitN(s, ".", 4)
 
+	// Ignore any components following major.minor.patch.
 	semVers := []uint16{0, 0, 0}
-	for i, v := range split {
-		if i >= 3 {
-			// Ignore any components following major.minor.patch.
-			break
-		}
-		ver, err := strconv.ParseUint(v, 10, 16)
+	for i := range min(len(semVers), len(split)) {
+		ver, err := strconv.ParseUint(split[i], 10, 16)
 		if err != nil {
 			return Version{}, fmt.Errorf("version: failed to parse SemVer '%s': %w", s, err)
 		}
diff --git a/go/extra/extract-metrics/main.go b/go/extra/extract-metrics/main.go
@@ -78,9 +78,8 @@ func markdownTable(metrics map[string]Metric) string {
 		}
 		desc := html.EscapeString(m.Help)
 		labels := strings.Join(m.Labels, ", ")
-
-		mdTable.WriteString(fmt.Sprintf("%s | %s | %s | %s | [%s](%s)\n", m.Name, m.Type, desc,
-			labels, pkg, fileURL))
+		row := fmt.Sprintf("%s | %s | %s | %s | [%s](%s)\n", m.Name, m.Type, desc, labels, pkg, fileURL)
+		mdTable.WriteString(row)
 	}
 
 	return mdTable.String()
diff --git a/go/go.mod b/go/go.mod
@@ -1,6 +1,6 @@
 module github.com/oasisprotocol/oasis-core/go
 
-go 1.25.5
+go 1.26.0
 
 replace (
 	github.com/cometbft/cometbft => github.com/oasisprotocol/cometbft v0.37.18-oasis1
diff --git a/go/oasis-net-runner/fixtures/file.go b/go/oasis-net-runner/fixtures/file.go
@@ -17,7 +17,7 @@ const (
 // newFixtureFromFile parses given JSON file and creates new fixture object from it.
 func newFixtureFromFile(path string) (*oasis.NetworkFixture, error) {
 	f := oasis.NetworkFixture{}
-	data, err := os.ReadFile(path)
+	data, err := os.ReadFile(path) //nolint:gosec
 	if err != nil {
 		return nil, fmt.Errorf("newFixtureFromFile: failed to open fixture file: %w", err)
 	}
diff --git a/go/oasis-test-runner/scenario/e2e/runtime/runtime_upgrade.go b/go/oasis-test-runner/scenario/e2e/runtime/runtime_upgrade.go
@@ -247,7 +247,7 @@ func (s *bundleServer) handleGetMetadata(w http.ResponseWriter, r *http.Request)
 	w.Header().Set("Content-Disposition", "attachment; filename=metadata.txt")
 	w.Header().Set("Content-Type", "application/octet-stream")
 	w.WriteHeader(http.StatusOK)
-	_, _ = w.Write(content)
+	_, _ = w.Write(content) //nolint:gosec
 
 	atomic.AddUint64(&s.requestCount, 1)
 }
@@ -261,7 +261,7 @@ func (s *bundleServer) handleGetBundle(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	content, err := os.ReadFile(path)
+	content, err := os.ReadFile(path) //nolint:gosec
 	if err != nil {
 		http.Error(w, "Error reading bundle", http.StatusInternalServerError)
 		return
@@ -270,7 +270,7 @@ func (s *bundleServer) handleGetBundle(w http.ResponseWriter, r *http.Request) {
 	w.Header().Set("Content-Disposition", "attachment; filename=bundle.orc")
 	w.Header().Set("Content-Type", "application/octet-stream")
 	w.WriteHeader(http.StatusOK)
-	_, _ = w.Write(content)
+	_, _ = w.Write(content) //nolint:gosec
 
 	atomic.AddUint64(&s.requestCount, 1)
 }
diff --git a/go/runtime/bundle/manager.go b/go/runtime/bundle/manager.go
@@ -644,7 +644,7 @@ func (m *Manager) fetchBundle(url string) (string, error) {
 	defer func() {
 		file.Close()
 		if err != nil {
-			_ = os.Remove(file.Name())
+			_ = os.Remove(file.Name()) //nolint:gosec
 		}
 	}()
 
diff --git a/go/runtime/log/log.go b/go/runtime/log/log.go
@@ -68,11 +68,11 @@ func (l *Log) rotate() error {
 	if err := l.file.Close(); err != nil {
 		return fmt.Errorf("failed to close file for rotation: %w", err)
 	}
-	if err := os.Remove(l.file.Name()); err != nil {
+	if err := os.Remove(l.file.Name()); err != nil { //nolint:gosec
 		return fmt.Errorf("failed to remove file for rotation: %w", err)
 	}
 
-	file, err := os.OpenFile(l.file.Name(), os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0o644)
+	file, err := os.OpenFile(l.file.Name(), os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0o644) //nolint:gosec
 	if err != nil {
 		return fmt.Errorf("failed to reopen file for rotation: %w", err)
 	}
diff --git a/tests/upgrade/post/go.mod b/tests/upgrade/post/go.mod
@@ -1,6 +1,6 @@
 module github.com/oasisprotocol/oasis-core/test-upgrade
 
-go 1.25.5
+go 1.26.0
 
 replace (
 	github.com/cometbft/cometbft => github.com/oasisprotocol/cometbft v0.37.2-oasis1

Original file line number	Diff line number	Diff line change
`@@ -90,10 +90,10 @@ func TestBoxIntegration(t *testing.T, impl Box, ctor func([]byte) (cipher.AEAD,`
`90`	`90`	`for i := range n {`
`91`	`91`	`n[i] = byte(i)`
`92`	`92`	`}`
`93`		`- for i := range aad {`
	`93`	`+ for i := range len(aad) {`
`94`	`94`	`aad[i] = byte(i + nonceSize)`
`95`	`95`	`}`
`96`		`- for i := range msg {`
	`96`	`+ for i := range len(msg) {`
`97`	`97`	`msg[i] = byte(i + nonceSize + len(aad))`
`98`	`98`	`}`
`99`	`99`
Original file line number	Diff line number	Diff line change
`@@ -457,7 +457,7 @@ func (tl TCBLevel) matches(sgxCompSvn [16]int32, tdxCompSvn [16]byte, pcesvn u`
`457`	`457`	`// otherwise move to the next item on TCB Levels list.`
`458`	`458`	`for i, comp := range tl.TCB.SGXComponents {`
`459`	`459`	`// At least one SVN is lower, no match.`
`460`		`- if sgxCompSvn[i] < comp.SVN {`
	`460`	`+ if sgxCompSvn[i] < comp.SVN { //nolint:gosec`
`461`	`461`	`return false`
`462`	`462`	`}`
`463`	`463`	`}`