Merge pull request #6520 from oasisprotocol/martin/bugfix/is-node-running

go/oasis-node/cmd/common: Fix isNodeRunning function

Author: martintomazic

.changelog/6520.bugfix.md

@@ -0,0 +1,4 @@
+go/oasis-node/cmd/common: Fix is node running helper
+
+Now the helper tries to dial the node socket to check
+whether the node is running.

go/oasis-node/cmd/common/common.go

@@ -6,9 +6,12 @@ import (
 	"fmt"
 	"io"
 	"io/fs"
+	"net"
 	"os"
 	"path/filepath"
 	"strings"
+	"syscall"
+	"time"
 
 	"github.com/spf13/cobra"
 	flag "github.com/spf13/pflag"
@@ -77,11 +80,14 @@ func InternalSocketPath() string {
 func IsNodeRunning() (bool, error) {
 	path := InternalSocketPath()
 
-	if _, err := os.Stat(path); err != nil {
-		if errors.Is(err, fs.ErrNotExist) {
-			return false, nil
-		}
-		return false, fmt.Errorf("stat %s: %w", path, err)
+	conn, err := net.DialTimeout("unix", path, time.Second)
+	switch {
+	case err == nil:
+		_ = conn.Close()
+	case errors.Is(err, fs.ErrNotExist) || errors.Is(err, syscall.ECONNREFUSED):
+		return false, nil
+	default:
+		return false, fmt.Errorf("failed to dial internal socket %s: %w", path, err)
 	}
 
 	return true, nil