Fixup: Add logging

Author: martintomazic

go/oasis-node/cmd/storage/checkpoint.go

@@ -83,14 +83,19 @@ func newCreateCmd() *cobra.Command {
 					return fmt.Errorf("failed to open consensus state DB: %w", err)
 				}
 				defer close()
-
 				return createCheckpoints(ctx, ndb, common.Namespace{}, height, outputDir)
 			}
 			if height != 0 { // TODO handle zero value vs not set correctly.
 				consensusOutDir := filepath.Join(outDir, consensusSubdir)
+				logger.Info("creating consensus checkpoint",
+					"height", height,
+					"output_dir", consensusOutDir,
+				)
 				if err := createConsensusCp(consensusOutDir); err != nil {
 					return fmt.Errorf("failed to create consensus checkpoint (height: %d): %w", height, err)
 				}
+				logger.Info("consensus checkpoint created")
+
 				if err := createCometBFTBootstrapMeta(dataDir, height, consensusOutDir); err != nil {
 					return fmt.Errorf("failed to write bootstrap metadata: %w", err)
 				}
@@ -103,7 +108,6 @@ func newCreateCmd() *cobra.Command {
 					return fmt.Errorf("failed to open runtime state DB: %w", err)
 				}
 				defer ndb.Close()
-
 				return createCheckpoints(ctx, ndb, ns, round, outputDir)
 			}
 			if runtimeID != "" {
@@ -112,9 +116,15 @@ func newCreateCmd() *cobra.Command {
 					return fmt.Errorf("malformed source runtime ID: %q: %w", runtimeID, err)
 				}
 				rtOutDir := filepath.Join(outDir, runtimesSubdir, ns.Hex())
+				logger.Info("creating runtime checkpoints (may take minutes to hours depending on the db size)",
+					"round", round,
+					"output_dir", rtOutDir,
+					"runtime_id", ns,
+				)
 				if err := createRuntimeCps(ns, rtOutDir); err != nil {
 					return fmt.Errorf("failed to create runtime checkpoints (runtime: %s, round: %d): %w", runtimeID, round, err)
 				}
+				logger.Info("runtime checkpoints created", "runtime_id", ns)
 			}
 
 			return nil
@@ -154,9 +164,11 @@ func newImportCmd() *cobra.Command {
 			_, err := os.ReadDir(consensusInputDir)
 			switch {
 			case err == nil:
+				logger.Info("restoring consensus checkpoint", "input_dir", inputDir)
 				if err := restoreConsensusCp(consensusInputDir); err != nil {
 					return fmt.Errorf("failed to restore consensus cp (input dir: %s): %w", consensusInputDir, err)
 				}
+				logger.Info("consensus checkpoint restored")
 
 				meta, err := readCometBFTBootstrapMeta(consensusInputDir)
 				if err != nil {
@@ -178,7 +190,6 @@ func newImportCmd() *cobra.Command {
 					return err
 				}
 				defer ndb.Close()
-
 				return restoreCheckpoints(ctx, ndb, ns, inputDir)
 			}
 			runtimeInputDir := filepath.Join(inputDir, runtimesSubdir)
@@ -192,9 +203,14 @@ func newImportCmd() *cobra.Command {
 					}
 					rtCpsDir := filepath.Join(runtimeInputDir, entry.Name())
 
+					logger.Info("restoring runtime checkpoints (may take few minutes)",
+						"runtime_id", ns,
+						"input_dir", inputDir,
+					)
 					if err := restoreRuntimeCp(rtCpsDir, ns); err != nil {
 						return fmt.Errorf("failed to import checkpoints (checkpoint dir: %s): %w", rtCpsDir, err)
 					}
+					logger.Info("runtime checkpoints restored", "runtime_id", ns)
 				}
 			case os.IsNotExist(err):
 				// No runtime checkpoints to restore