Skip to content

Commit 923c916

Browse files
authored
Merge pull request #6468 from oasisprotocol/peternose/bugfix/skip-km-committee-elections
go/consensus/cometbft/apps/scheduler: Skip key manager runtimes
2 parents f1ef5c2 + 450646e commit 923c916

3 files changed

Lines changed: 11 additions & 2 deletions

File tree

.buildkite/code.pipeline.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -378,6 +378,7 @@ steps:
378378
- make build-helpers
379379
- export OASIS_STORAGE_PROTOCOL_SERVER_BINARY=$(realpath go/storage/mkvs/interop/mkvs-test-helpers)
380380
- .buildkite/rust/coverage.sh
381+
soft_fail: true
381382
retry:
382383
<<: *retry_agent_failure
383384
plugins:

.changelog/6468.bugfix.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
go/consensus/cometbft/apps/scheduler: Skip key manager runtimes

go/consensus/cometbft/apps/scheduler/shuffle.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,15 @@ func electCommittee(
134134
)
135135

136136
// Only generic compute runtimes need to elect all the committees.
137-
if !rt.IsCompute() && kind != scheduler.KindComputeExecutor {
138-
return nil
137+
switch isFeatureVersion242 {
138+
case false:
139+
if !rt.IsCompute() && kind != scheduler.KindComputeExecutor {
140+
return nil
141+
}
142+
case true:
143+
if !rt.IsCompute() || kind != scheduler.KindComputeExecutor {
144+
return nil
145+
}
139146
}
140147

141148
members, err := electCommitteeMembers(

0 commit comments

Comments
 (0)