Merge pull request #6189 from yetyear/master

refactor: use a more modern writing style

Author: peternose

.changelog/6189.trivial.md

@@ -157,7 +157,7 @@ func (e *testEntry) Size() uint64 {
 
 func makeEntries(nr int) []*testEntry {
 	vec := make([]*testEntry, 0, nr)
-	for i := 0; i < nr; i++ {
+	for i := range nr {
 		vec = append(vec, makeEntry(fmt.Sprintf("key-%d", i)))
 	}
 

go/common/cache/lru/lru_test.go

@@ -399,7 +399,7 @@ func loadCacheGlibc() (*Cache, error) {
 		return nil, errUnsupported
 	}
 
-	for i := 0; i < nlibs; i++ {
+	for i := range nlibs {
 		rawE := rawLibs[entrySz*i : entrySz*(i+1)]
 
 		e := new(cacheEntry)

go/common/dynlib/cache.go

@@ -4,6 +4,7 @@ import (
 	"encoding"
 	"errors"
 	"math/big"
+	"slices"
 )
 
 var (
@@ -38,7 +39,7 @@ func (q *Quantity) Clone() *Quantity {
 
 // MarshalBinary encodes a Quantity into binary form.
 func (q *Quantity) MarshalBinary() ([]byte, error) {
-	return append([]byte{}, q.inner.Bytes()...), nil
+	return slices.Clone(q.inner.Bytes()), nil
 }
 
 // UnmarshalBinary decodes a byte slice into a Quantity.

go/common/quantity/quantity.go

@@ -22,18 +22,18 @@ func TestOne(t *testing.T) {
 
 		// All functions should start and stop if there is big enough time gap
 		// between starts.
-		for i := 0; i < 3; i++ {
+		for range 3 {
 			require.True(one.TryStart(noopFn))
 			time.Sleep(time.Millisecond)
 		}
 
 		// All stops should fail as no function is running.
-		for i := 0; i < 3; i++ {
+		for range 3 {
 			require.False(one.TryStop())
 		}
 
 		// Starting functions again should not be a problem.
-		for i := 0; i < 3; i++ {
+		for range 3 {
 			require.True(one.TryStart(noopFn))
 			time.Sleep(time.Millisecond)
 		}
@@ -46,14 +46,14 @@ func TestOne(t *testing.T) {
 
 		// First function should start, others not.
 		require.True(one.TryStart(blockFn))
-		for i := 0; i < 3; i++ {
+		for range 3 {
 			require.False(one.TryStart(blockFn))
 		}
 
 		// As one function is running, the first stop should succeed,
 		// others not.
 		require.True(one.TryStop())
-		for i := 0; i < 3; i++ {
+		for range 3 {
 			require.False(one.TryStop())
 		}