Skip to content

oasis-core/go/oasis-test-runner: Add observer fixture and e2e test#6497

Merged
martintomazic merged 4 commits intomasterfrom
martin/trivial/observer-e2e-test
Apr 14, 2026
Merged

oasis-core/go/oasis-test-runner: Add observer fixture and e2e test#6497
martintomazic merged 4 commits intomasterfrom
martin/trivial/observer-e2e-test

Conversation

@martintomazic
Copy link
Copy Markdown
Contributor

Closes #6495

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 12, 2026

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 9b99580
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-oasis-core/deploys/69de540fe4da400008a613b5

@martintomazic martintomazic changed the title oasis-core/go/oasis-test-runner: Add observer fixture and e2e observer test oasis-core/go/oasis-test-runner: Add observer fixture and e2e test Apr 12, 2026
Comment thread go/oasis-test-runner/oasis/fixture.go
@martintomazic martintomazic force-pushed the martin/trivial/observer-e2e-test branch 2 times, most recently from 6ebfe64 to 4d10ab4 Compare April 13, 2026 08:36
@martintomazic martintomazic force-pushed the martin/trivial/observer-e2e-test branch from 4d10ab4 to f09088e Compare April 13, 2026 08:43
@martintomazic
Copy link
Copy Markdown
Contributor Author

martintomazic commented Apr 13, 2026

SGX tests seems to be failing because of the CI runner issue: see

Update: was fixed.

--scenario e2e/runtime/rofl
--scenario e2e/runtime/trust-root/.+
--scenario e2e/runtime/keymanager-.+
--scenario e2e/runtime/observer
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to run this in non-sgx mode we would have to fix:
https://github.com/oasisprotocol/oasis-core/blob/master/go/worker/keymanager/secrets.go#L245:L264. I.e. in non-sgx mode access list obtained from the consensus registered nodes is not applied.

Imo out of scope, also fine with stronger test albeit less practical to test locally.

@martintomazic martintomazic marked this pull request as ready for review April 13, 2026 09:25
@martintomazic martintomazic requested a review from kostko April 13, 2026 09:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.60%. Comparing base (4ab1cc1) to head (f09088e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6497      +/-   ##
==========================================
+ Coverage   64.52%   64.60%   +0.08%     
==========================================
  Files         698      698              
  Lines       68208    68220      +12     
==========================================
+ Hits        44012    44075      +63     
+ Misses      19139    19095      -44     
+ Partials     5057     5050       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martintomazic martintomazic self-assigned this Apr 14, 2026
Copy link
Copy Markdown
Collaborator

@peternose peternose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread go/oasis-test-runner/oasis/fixture.go
Comment thread go/oasis-test-runner/scenario/e2e/runtime/observer.go Outdated
Comment thread go/oasis-test-runner/scenario/e2e/runtime/observer.go
Comment thread go/oasis-test-runner/scenario/e2e/runtime/observer.go
@peternose
Copy link
Copy Markdown
Collaborator

The file .changelog/6495.trivial.md could also be renamed to .changelog/6497.trivial.md, to point to PR not the issue. As an issue could have multiple PRs, with different commits which are seen in the changelog.

Test needs to run in SGX mode else keymanager's access list
constructed using registered nodes is ignored.
@martintomazic martintomazic force-pushed the martin/trivial/observer-e2e-test branch from f09088e to 9b99580 Compare April 14, 2026 14:49
@martintomazic martintomazic enabled auto-merge April 14, 2026 14:52
@martintomazic martintomazic merged commit 3b29b09 into master Apr 14, 2026
5 checks passed
@martintomazic martintomazic deleted the martin/trivial/observer-e2e-test branch April 14, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oasis-core/go/oasis-test-runner: Add observer fixture and e2e observer test

3 participants