oasis-core/go/oasis-test-runner: Add observer fixture and e2e test#6497
oasis-core/go/oasis-test-runner: Add observer fixture and e2e test#6497martintomazic merged 4 commits intomasterfrom
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
6ebfe64 to
4d10ab4
Compare
4d10ab4 to
f09088e
Compare
|
SGX tests seems to be failing because of the CI runner issue: see Update: was fixed. |
| --scenario e2e/runtime/rofl | ||
| --scenario e2e/runtime/trust-root/.+ | ||
| --scenario e2e/runtime/keymanager-.+ | ||
| --scenario e2e/runtime/observer |
There was a problem hiding this comment.
To be able to run this in non-sgx mode we would have to fix:
https://github.com/oasisprotocol/oasis-core/blob/master/go/worker/keymanager/secrets.go#L245:L264. I.e. in non-sgx mode access list obtained from the consensus registered nodes is not applied.
Imo out of scope, also fine with stronger test albeit less practical to test locally.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6497 +/- ##
==========================================
+ Coverage 64.52% 64.60% +0.08%
==========================================
Files 698 698
Lines 68208 68220 +12
==========================================
+ Hits 44012 44075 +63
+ Misses 19139 19095 -44
+ Partials 5057 5050 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The file |
Test needs to run in SGX mode else keymanager's access list constructed using registered nodes is ignored.
f09088e to
9b99580
Compare
Closes #6495