go/runtime/host: Improve common.GetQuotePolicy function#6531
Merged
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
martintomazic
commented
May 21, 2026
d85eb0c to
b7140f0
Compare
peternose
reviewed
May 27, 2026
9460bdf to
4b0af05
Compare
Contributor
Author
|
Things can get further simplified now:
runtime/host/attestation/policy.go
QuotePolicyProvider
runtime/host/attestation/??.go
UpdateRuntimeQuote
EndorseCapabilityTEE
runtime/host/attestation/worker.go
AttestationWorker
runtime/host/attestation/metrics.go
InitMetrics
UpdateAttestationMetrics |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6531 +/- ##
==========================================
+ Coverage 63.75% 63.83% +0.07%
==========================================
Files 698 697 -1
Lines 68293 68166 -127
==========================================
- Hits 43542 43511 -31
+ Misses 19757 19675 -82
+ Partials 4994 4980 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
peternose
reviewed
Jun 8, 2026
peternose
approved these changes
Jun 8, 2026
peternose
left a comment
Collaborator
There was a problem hiding this comment.
further simplified now
I would do this in another PR, if needed.
This will allow us to remove consensus dependency in the subsequent commits.
This enables us to get rid of the consensus dependency.
Logic should not be nested in the common packages.
4b0af05 to
21d5e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial, semantics should be preserved.
Tackles #6474 (comment).