The failed transaction operations is empty in rosetta api

[zhanghuize-git]

Hello team, I am a cex dev, when I use rosetta-api, I find some issuse

When I use api to get transaction details
curl --location 'https://rosetta.oasis.io/api/mainnet/v1/block' \ --header 'content-type: application/json;' \ --data '{ "network_identifier": { "blockchain": "Oasis", "network": "bb3d748def55bdfb797a2ac53ee6ee141e54cd2ab2dc2375f4a0703a178e6e55" }, "block_identifier": { "index": 27765187 } }'

it response
{ "transaction_identifier": { "hash": "bbf683d62ae8f0278178a96d62e4d683fee4ea2bc908c313b59f3d4ed330f26e" }, "operations": [] },

the bbf683d62ae8f0278178a96d62e4d683fee4ea2bc908c313b59f3d4ed330f26e transaction is failed status

when I check source code, I find this code has bug

this is result by GetTransactionsWithResults api get

please fix it, thank you

[pro-wh]

Hi, can you post an explanation of the issue and/or bug? Is this not correct for the failed, no-fee, non-staking transaction not to perform any operations on the info that Rosetta tracks?

[zhanghuize-git]

When an exchange is scanning the blockchain, if a transaction fails and its operation is related to the exchange, the operations data in the transaction are required.

[pro-wh]

so you mean hypothetically for a successful no-fee, non-staking transaction? that should also have empty operations in my understanding. can you confirm that's the case on a successful roothash/commitment transaction?

[zhanghuize-git]

I mean, for failed transactions, there should also be data in the corresponding operations, not an empty array. In this way, I can know what happened to this failed transaction, its from address, to address, and what is the amount.

[pro-wh]

this transaction is not a token transfer, so its true operations array is the empty array

[zhanghuize-git]

For other failed token transactions, is the actual operation array an empty array? Are there corresponding reference transactions?

[pro-wh]

the code looks like it's written to generate some hypothetical failed operations for failed transactions. but be aware that there are different categories of failed transactions with the transaction fee being used or not used. I checked our running list of "interesting" blocks oasisprotocol/explorer#109 but I don't see any curated instances of failed consensus layer staking operations.

if you know of any staking transfer or delegate transactions, could you check if those are represented correctly in Rosetta?