Support non-encrypted variables in ROFL manifest yaml#2481
Merged
Conversation
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2481 +/- ##
==========================================
- Coverage 51.35% 51.35% -0.01%
==========================================
Files 237 237
Lines 17236 17251 +15
==========================================
+ Hits 8852 8859 +7
- Misses 8324 8332 +8
Partials 60 60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks
martintomazic
commented
Jun 28, 2026
251da77 to
1dc8747
Compare
4 tasks
4 tasks
kostko
approved these changes
Jun 30, 2026
Operator might still accidentally override proxy env variables.
1dc8747 to
b88002f
Compare
github-actions Bot
added a commit
that referenced
this pull request
Jul 1, 2026
…artin/feature/rofl-public-config Support non-encrypted variables in ROFL manifest yaml 082159a
github-actions Bot
added a commit
that referenced
this pull request
Jul 1, 2026
…artin/feature/rofl-public-config Support non-encrypted variables in ROFL manifest yaml 082159a
github-actions Bot
added a commit
that referenced
this pull request
Jul 1, 2026
…/martin/feature/rofl-public-config Support non-encrypted variables in ROFL manifest yaml 082159a
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Jul 1, 2026
…sisprotocol/martin/feature/rofl-public-config Support non-encrypted variables in ROFL manifest yaml 082159a
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Jul 1, 2026
…oasisprotocol/martin/feature/rofl-public-config Support non-encrypted variables in ROFL manifest yaml 082159a
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Jul 1, 2026
…sisprotocol/martin/feature/rofl-public-config Support non-encrypted variables in ROFL manifest yaml 082159a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2248.
What
Keys that are part of the rofl instance metadata and start with
.envprefix are passed as part of the env file during rofl containers init, like is currently done for the rofl secrets.E2E testing
Created simple tdx instance that printed container secrets, normal secrets, and "public" variable using
.envmetadata convention above. Used local build of rofl containers, and tested on the Sapphire testnet.Consideration
Like with secrets we expect the admin to not shoot itself by e.g.:
Follow-up
Alternative solution from #2248 (comment) can be done as follow-up without being breaking, and will be in fact complementary.