Ah/feat add token watcher mode#11
Merged
Merged
Conversation
ahmedhamedaly
requested review from
njelich and
rube-de
and removed request for
njelich
December 23, 2025 07:07
njelich
reviewed
Dec 28, 2025
njelich
approved these changes
Jan 5, 2026
rube-de
reviewed
Jan 5, 2026
rube-de
left a comment
rube-de
left a comment
Collaborator
There was a problem hiding this comment.
We have tests with mock for the other modes, we should also have it for this mode.
| except Exception as e: | ||
| logger.error(f"Error in token watcher: {e}", exc_info=True) | ||
|
|
||
| async def _check_block_for_token_transfers(self, block_number: int) -> bool: |
Collaborator
There was a problem hiding this comment.
I can't see this called anywhere.
If this is some old function, I recommend to remove it.
| to_remove = list(self.processed_tx_hashes)[ | ||
| : self.max_tx_cache_size // 2 | ||
| ] | ||
| self.processed_tx_hashes -= set(to_remove) |
Collaborator
There was a problem hiding this comment.
set doesn't guarantee insertion order in python and you could remove a recent hash instead of the oldest
I would recommend to use dict with insertion-order keys.
Some unit tests for this case may be helpful
| if start_block > latest_block_number: | ||
| return | ||
|
|
||
| end_block = min(start_block + 100, latest_block_number) |
Collaborator
There was a problem hiding this comment.
Preferable not use magic numbers.
Many free RPCs also limit max blocks to 10, I would commend to have this configurable, as we have it with batch_size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.