Skip to content

Export icons#23

Closed
lubej wants to merge 2 commits into
masterfrom
ml/icons
Closed

Export icons#23
lubej wants to merge 2 commits into
masterfrom
ml/icons

Conversation

@lubej
Copy link
Copy Markdown
Collaborator

@lubej lubej commented Jun 4, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2025

Deployed to Cloudflare Pages

Latest commit: 60760ccd1c1d46990563e3c12dd2b4972d6b2bee
Status:✅ Deploy successful!
Preview URL: https://efff4d06.oasis-ui.pages.dev
Alias: https://pr-23.oasis-ui.pages.dev

@lubej lubej requested review from buberdds, csillag and lukaw3d June 4, 2025 08:04
Comment thread src/icons/index.ts
@@ -0,0 +1 @@
export * as Icons from 'lucide-react'
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using alias here, due to a fact that there are some conflicts with component names.

@lubej
Copy link
Copy Markdown
Collaborator Author

lubej commented Jun 4, 2025

This is more of a proposal, including the icons increases the bundle(by including every icon). But avoid the hustle to install lucide-react in each of the project that uses the library and possible version differences.

edit: It should be possible to include lucide-react as peerDependency, but for some reason I couldn't get the build to work properly.

@lubej lubej closed this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant