Refactor Tooltip component #27
Conversation
Deployed to Cloudflare Pages
|
eb23dab to
100cc2b
Compare
lubej
left a comment
There was a problem hiding this comment.
I am not in favor of modifying the original components of shadcn. As the docs we will be referring to are still the original dev docs. I would rather see we would create wrapper version of the component. Especially if we are going to use generation tools, which would always generate "wrong" tooltip, and would always require manual changes. Can we maybe discuss this in more detail on next FE sync, on how to manage "custom" components?
|
Sure let's chat tomorrow. For now I can bring back original tooltip and add wrapper as a separate component. For generation tools no clue how they gonna work. |
95f02b5 to
1a35695
Compare
|
For Sync meeting:
|
99b92bb to
9367ac9
Compare
Closes #24
https://pr-27.oasis-ui.pages.dev/?path=/docs/components-tooltip--docs&globals=theme:light
vs current
https://oasis-ui.pages.dev/?path=/docs/components-tooltip--docs&globals=theme:light
instead of