Skip to content

Refactor Tooltip component #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buberdds merged 5 commits into from
Jul 24, 2025
Merged

Refactor Tooltip component #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0efbd88
Add custom Tooltip component
buberdds Jul 24, 2025
9bd0c48
Add custom Tooltip to stories
buberdds Jul 24, 2025
cab880f
Remove arrow from custom Tooltip to match designs
buberdds Jul 24, 2025
12a5eeb
Adjust custom Tooltip styling to match designs
buberdds Jul 24, 2025
8812c6a
Limit tooltip content max width
buberdds Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/components/tooltip/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import * as React from 'react'
import { Tooltip as BaseTooltip, TooltipTrigger, TooltipContent } from '../ui/tooltip'

type TooltipProps = React.ComponentProps<typeof BaseTooltip> & {
title: React.ReactNode
} & Pick<React.ComponentProps<typeof TooltipContent>, 'side' | 'sideOffset' | 'align'>

const TooltipContentNoArrow = ({
children,
sideOffset = 8, // Needed when arrow is hidden
...props
}: React.ComponentProps<typeof TooltipContent>) => {
return (
<TooltipContent
className="[&>span]:hidden max-w-[400px] text-pretty bg-base-popover border text-popover-foreground shadow-[0px_2px_4px_-1px_rgba(0,0,0,0.06)] shadow-md"
sideOffset={sideOffset}
{...props}
>
{children}
</TooltipContent>
)
}

export const Tooltip = ({ title, children, side, sideOffset, align, ...props }: TooltipProps) => {
return (
<BaseTooltip {...props}>
<TooltipTrigger asChild>{children}</TooltipTrigger>
<TooltipContentNoArrow side={side} sideOffset={sideOffset} align={align}>
{title}
</TooltipContentNoArrow>
</BaseTooltip>
)
}
74 changes: 11 additions & 63 deletions src/stories/Tooltip/Tooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { Meta, StoryObj } from '@storybook/react-vite'
import { Tooltip, TooltipContent, TooltipTrigger } from '../../components/ui/tooltip.tsx'
import { Tooltip } from '../../components/tooltip'
import { Button } from '../../components/ui/button.tsx'
import { expect, within } from 'storybook/test'

Expand All @@ -21,8 +21,14 @@ const meta: Meta<typeof Tooltip> = {
},
tags: ['autodocs'],
argTypes: {
defaultOpen: {
control: 'boolean',
title: {
control: 'text',
description: 'The content of the tooltip',
},
side: {
control: { type: 'radio' },
options: ['top', 'right', 'bottom', 'left'],
description: 'The preferred side of the trigger to render against',
},
open: {
control: 'boolean',
Expand All @@ -38,70 +44,12 @@ type Story = StoryObj<typeof meta>

export const Default: Story = {
args: {
children: (
<>
<TooltipTrigger>
<Button variant="outline">Hover me</Button>
</TooltipTrigger>
<TooltipContent>
<p>Tooltip content</p>
</TooltipContent>
</>
),
title: 'Tooltip content',
children: <Button variant="outline">Hover me</Button>,
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement)
const button = canvas.getAllByRole('button', { name: 'Hover me' })[0]
await expect(button).toBeInTheDocument()
},
}

export const Variants: Story = {
args: {
children: (
<div className="flex flex-col items-center gap-4">
<div className="flex justify-center gap-4">
<Tooltip>
<TooltipTrigger>
<Button variant="outline">Top</Button>
</TooltipTrigger>
<TooltipContent side="top">
<p>Tooltip on top</p>
</TooltipContent>
</Tooltip>
</div>

<div className="flex justify-between gap-16">
<Tooltip>
<TooltipTrigger>
<Button variant="outline">Left</Button>
</TooltipTrigger>
<TooltipContent side="left">
<p>Tooltip on left</p>
</TooltipContent>
</Tooltip>

<Tooltip>
<TooltipTrigger>
<Button variant="outline">Right</Button>
</TooltipTrigger>
<TooltipContent side="right">
<p>Tooltip on right</p>
</TooltipContent>
</Tooltip>
</div>

<div className="flex justify-center gap-4">
<Tooltip>
<TooltipTrigger>
<Button variant="outline">Bottom</Button>
</TooltipTrigger>
<TooltipContent side="bottom">
<p>Tooltip on bottom</p>
</TooltipContent>
</Tooltip>
</div>
</div>
),
},
}