Skip to content

Create custom Alert component#55

Merged
buberdds merged 2 commits into
masterfrom
mz/alert
Aug 20, 2025
Merged

Create custom Alert component#55
buberdds merged 2 commits into
masterfrom
mz/alert

Conversation

@buberdds
Copy link
Copy Markdown
Collaborator

@buberdds buberdds commented Aug 15, 2025

Waits for design validation https://pr-55.oasis-ui.pages.dev/?path=/docs/components-alert--docs&globals=theme:light

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 15, 2025

Deployed to Cloudflare Pages

Latest commit: 25b7edf122b960051a8c5e6f43b6756f5c1b51a1
Status:✅ Deploy successful!
Preview URL: https://ec0fec83.oasis-ui.pages.dev
Alias: https://pr-55.oasis-ui.pages.dev

@donouwens
Copy link
Copy Markdown

@buberdds , I think these are great!

Two small questions;

  1. Why are we showing >_ as an icon on the info state? Perhaps we can use this icon?
  2. Perhaps we need a success state as well (both empty and filled)?

@buberdds buberdds force-pushed the mz/alert branch 2 times, most recently from 2674391 to 2e00225 Compare August 18, 2025 11:08
@buberdds
Copy link
Copy Markdown
Collaborator Author

@donouwens thx for feedback

  1. No idea why it is used in a design guide. Anyway, replaced with info.
  2. Added success variants

@buberdds
Copy link
Copy Markdown
Collaborator Author

This is accepted by @donouwens, moving to code review

@buberdds buberdds merged commit d027194 into master Aug 20, 2025
4 checks passed
@buberdds buberdds deleted the mz/alert branch August 20, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants