Merge pull request #2161 from oasisprotocol/lw/rm-cy

Migrate Cypress e2e tests to playwright and remove Oasis Monitor docker config

Author: lukaw3d

.babelrc

@@ -0,0 +1 @@
+Migrate Cypress e2e tests to Playwright and remove Oasis Monitor docker config

.changelog/2161.internal.md

@@ -91,40 +91,10 @@ jobs:
           path: playwright/test-results
           retention-days: 5
 
-  cypress:
-    # NOTE: This name appears in GitHub's Checks API.
-    name: cypress
-    needs: [yarn_cache]
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-      - name: Set up Node.js 18
-        uses: actions/setup-node@v4
-        with:
-          node-version: '18.x'
-          cache: yarn
-      - name: Install dependencies
-        run: yarn install --frozen-lockfile
-      - run: docker compose pull
-      - uses: satackey/action-docker-layer-caching@v0.0.11
-        # Ignore the failure of a step and avoid terminating the job.
-        continue-on-error: true
-      - run: NODE_ENV=test REACT_APP_LOCALNET=1 REACT_APP_BACKEND=oasismonitor yarn start &
-      - run: docker compose up --build -d
-      - run: npx wait-on http://localhost:3000/ --timeout 60000
-      - run: yarn cypress:run
-      - name: 'Upload coverage report'
-        uses: actions/upload-artifact@v4
-        with:
-          name: cypress-coverage
-          path: cypress-coverage
-          retention-days: 5
-
   upload-coverage:
     # NOTE: This name appears in GitHub's Checks API.
     name: coverage
-    needs: [cypress, jest]
+    needs: [jest]
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
@@ -135,7 +105,3 @@ jobs:
         with:
           files: ./jest-coverage/coverage-final.json
           flags: jest
-      - uses: codecov/codecov-action@v3
-        with:
-          files: ./cypress-coverage/coverage-final.json
-          flags: cypress

.github/workflows/ci-test.yml

@@ -1,6 +1,5 @@
 # Don't check auto-generated stuff into git
 .parcel-cache/
-cypress-coverage/
 coverage/
 build/
 build-ext/
@@ -20,15 +19,5 @@ yarn-error.log*
 \#*
 .\#*
 
-# Docker
-/node
-/docker/oasis-node/node
-
 # Local debug
 debug*.c
-
-# Cypress
-/cypress/screenshots/
-/cypress/videos/
-/.nyc_output/
-/instrumented/

.gitignore

@@ -1,6 +1,5 @@
 build/
 node_modules/
-cypress/
 coverage/
 **/node/**
 package-lock.json

.prettierignore

@@ -20,8 +20,6 @@
   "typescriptHero.imports.insertSemicolons": false,
   "files.exclude": {
     "**/__snapshots__/": true,
-    ".nyc_output/": true,
-    "cypress-coverage/": true,
     "coverage/": true,
     ".parcel-cache/": true,
     "build/": true,

.vscode/settings.json

@@ -65,14 +65,6 @@ yarn install
 yarn start
 ```
 
-Alternatively, to get started with a local network:
-
-```shell
-docker-compose up --build -d
-yarn install
-REACT_APP_LOCALNET=1 yarn start
-```
-
 Then go to <http://localhost:3000> to access the wallet.
 
 ### Test accounts
@@ -93,9 +85,6 @@ oasis1qq5t7f2gecsjsdxmp5zxtwgck6pzpjmkvc657z6l
 
 ## Architecture
 
-This code needs multiple components to run, all provided in the
-[docker-compose.yml] for local development.
-
 ![Architecture diagram](docs/images/architecture.svg)
 
 - [envoy-proxy], used as a gRPC gateway for live access to the oasis-node, to
@@ -117,9 +106,9 @@ API that web wallet is using is determined during a build time.
 
 The repository has two different test strategies:
 
-- E2E (End-to-end) tests, run with [Cypress], located in [cypress/](/cypress).
-  These tests require the react app to be accessible on port `3000` and the
-  docker-compose stack to be up.
+- E2E (End-to-end) tests, run with [Playwright], located in
+  [playwright/](/playwright).
+  These tests require the react app to be accessible on port `3000`.
 - Unit & functional tests, run with [Jest], located throughout the codebase
 
 To run all tests:
@@ -138,12 +127,6 @@ yarn start
 # Or `yarn start:prod` and `yarn test:prod` to test production builds.
 # Or `xvfb-run yarn test` to prevent browser windows opening.
 
-# Run cypress tests
-docker-compose up -d
-# Run this in another terminal to keep it open
-REACT_APP_LOCALNET=1 REACT_APP_BACKEND=oasismonitor yarn start
-yarn cypress:run
-
 # Manually check that content-security-policy in getSecurityHeaders.js doesn't
 # break any functionality
 yarn start:prod
@@ -218,13 +201,11 @@ Adding a new language:
 
 [demo-video]: https://github.com/oasisprotocol/wallet/assets/3758846/ef11fbea-dd55-42b1-87a4-1b74509a2809
 [chromewebstore.google.com]: https://chromewebstore.google.com/detail/rose-wallet/ppdadbejkmjnefldpcdjhnkpbjkikoip
-[docker-compose.yml]: docker-compose.yml
 [envoy-proxy]: https://www.envoyproxy.io
 [oasis-nexus]: https://github.com/oasisprotocol/nexus
 [oasis-nexus-api-spec]: https://nexus.oasis.io/v1/spec/v1.html
 [oasis-scan]: https://www.oasisscan.com
 [scan-api-repo]: https://github.com/bitcat365/oasisscan-backend#oasisscan-api
-[Cypress]: https://www.cypress.io/
 [Jest]: https://github.com/facebook/jest
 [prettier]: https://prettier.io/
 [eslint]: https://github.com/eslint/eslint