Skip to content

feat(config): add 'tpl' usage for alphaConfig.existingSecret, alphaConfig.existingConfig, config.existingConfig, podAnnotations and podLabels#418

Open
kilianpaquier wants to merge 1 commit into
oauth2-proxy:mainfrom
kilianpaquier:feat/tpl-existingconfig
Open

feat(config): add 'tpl' usage for alphaConfig.existingSecret, alphaConfig.existingConfig, config.existingConfig, podAnnotations and podLabels#418
kilianpaquier wants to merge 1 commit into
oauth2-proxy:mainfrom
kilianpaquier:feat/tpl-existingconfig

Conversation

@kilianpaquier

@kilianpaquier kilianpaquier commented Jun 23, 2026

Copy link
Copy Markdown

Description

Hello Team 👋

A small PR to wrap existingConfig and existingSecret, podAnnotations and podLabels with tpl.

My use case is to create a configmap in my parent chart {{ .Release.Name }}-oauth2-proxy-custom because I want to use some .Values within the configuration (redirect_url for instance).

Addition for podAnnotations and podLabels is to add consistency with other annotations / labels tpl usage and also for the pod checksum/config.

Checklist:

  • I have bumped the version in the Chart.yaml according to Semantic Versioning.
  • I have updated the documentation/CHANGELOG at the bottom of the Chart.yaml
  • I have signed off all my commits.
  • (Optional) I have updated the Chart.lock for dependency updates
  • (Optional) I have implemented helm tests for new feature flags

@kilianpaquier

Copy link
Copy Markdown
Author

Hi @pierluigilenoci,

Thanks for the review, noted on all points, will do this tomorrow !

@kilianpaquier kilianpaquier force-pushed the feat/tpl-existingconfig branch from 4f2478b to dcf99ae Compare June 24, 2026 12:52
@kilianpaquier

kilianpaquier commented Jun 24, 2026

Copy link
Copy Markdown
Author

Hello @pierluigilenoci, added the suggested improvements, unit tests ran locally (hope it's still going to be fine on the CI).

EDIT: added tpl usage for podAnnotations and podLabels as it done also on deploymentAnnotations and deploymentLabels.

@kilianpaquier kilianpaquier changed the title feat(config): tpl existingConfig and existingSecret for alphaConfig and config feat(config): add missing tpl usage on existingConfig, existingSecret, podAnnotations and podLabels Jun 24, 2026
@kilianpaquier kilianpaquier changed the title feat(config): add missing tpl usage on existingConfig, existingSecret, podAnnotations and podLabels feat(config): add 'tpl' usage for alphaConfig.existingSecret, alphaConfig.existingConfig, config.existingConfig, podAnnotations and podLabels Jun 24, 2026
…nfig.existingConfig, config.existingConfig, podAnnotations and podLabels

Signed-off-by: kilianpaquier <git@kilianpaquier.dev>
@kilianpaquier kilianpaquier force-pushed the feat/tpl-existingconfig branch from dcf99ae to fbbf028 Compare June 24, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant