feat(config): add 'tpl' usage for alphaConfig.existingSecret, alphaConfig.existingConfig, config.existingConfig, podAnnotations and podLabels#418
Open
kilianpaquier wants to merge 1 commit into
Conversation
Author
|
Hi @pierluigilenoci, Thanks for the review, noted on all points, will do this tomorrow ! |
4f2478b to
dcf99ae
Compare
Author
|
Hello @pierluigilenoci, added the suggested improvements, unit tests ran locally (hope it's still going to be fine on the CI). EDIT: added tpl usage for podAnnotations and podLabels as it done also on deploymentAnnotations and deploymentLabels. |
…nfig.existingConfig, config.existingConfig, podAnnotations and podLabels Signed-off-by: kilianpaquier <git@kilianpaquier.dev>
dcf99ae to
fbbf028
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello Team 👋
A small PR to wrap existingConfig and existingSecret, podAnnotations and podLabels with
tpl.My use case is to create a configmap in my parent chart
{{ .Release.Name }}-oauth2-proxy-custombecause I want to use some.Valueswithin the configuration (redirect_url for instance).Addition for podAnnotations and podLabels is to add consistency with other annotations / labels tpl usage and also for the pod
checksum/config.Checklist: