Merge pull request #32 from obilodeau/fix-concurrency-bugs

Fixed important regressions due to socket.io and web server in eventlet affecting since 0.5.0 maybe even 0.4.0

Author: obilodeau

ceopardy/__init__.py

@@ -78,10 +78,13 @@
     # flask-cors is optional; prod serves everything from the same origin.
     pass
 
+# Use threading mode so the WSGI layer stays plain Werkzeug — its debugger
+# and exception logging just work. If someone fronts this with gunicorn
+# (see README), they pick the worker class at the CLI level (-k eventlet).
 socketio = SocketIO(
     app,
     cors_allowed_origins="*",
-    async_mode="eventlet",
+    async_mode="threading",
 )
 db = SQLAlchemy(app)
 

ceopardy/__main__.py

@@ -35,7 +35,10 @@ def _cmd_serve(args):
     print(f"  Host:   http://localhost:{port}/host")
     if debug:
         print("  Debug:  ON (verbose logging + auto-reload)")
-    socketio.run(app, host=host, port=port, debug=debug)
+    # Werkzeug is the only WSGI server we use here. Flask-SocketIO refuses it
+    # by default; we opt in because Ceopardy is meant for single-operator
+    # local use (binds to 127.0.0.1, see README on exposing via nginx).
+    socketio.run(app, host=host, port=port, debug=debug, allow_unsafe_werkzeug=True)
 
 
 def _walk(traversable, prefix=""):

run.py

@@ -25,4 +25,12 @@
     # debug=False.
     # WARNING: This app is not ready to be exposed on the network.
     #          Game host interface would be exposed.
-    socketio.run(app, host="127.0.0.1", port=5000, debug=True)
+    # allow_unsafe_werkzeug: Flask-SocketIO refuses Werkzeug otherwise. See
+    # the same opt-in (and rationale) in ceopardy/__main__.py:_cmd_serve.
+    socketio.run(
+        app,
+        host="127.0.0.1",
+        port=5000,
+        debug=True,
+        allow_unsafe_werkzeug=True,
+    )