Skip to content

Stage-7 follow-up: dead PreviewsCLI imports in two test files; icon redraw bundled into 3fbf39b #340

Description

@obj-p

Relayed from a /code-review run that targeted main HEAD 3fbf39b (stage-7 SDK narrowing). Both findings CONFIRMED by the review.

  1. Dead imports left after daemonChannelTransport moved to PreviewsTestSupport (build passes with them removed):

    • previewsmcp/Tests/PreviewsCLITests/NetworkTransportHeartbeatTests.swift:5 import PreviewsCLI
    • previewsmcp/Tests/MCPIntegrationTests/DaemonLifecycleTests.swift:4 import PreviewsCLI
  2. For the record (not fixable post-merge): 3fbf39b bundles an unrelated agent-icon redraw (assets/agent-icon.svg + embedded AppIcon.png + IOSAgentBuilderHashTests re-pin). A revert or bisect of stage 7 drags the icon change with it. Noting here so future bisects are not surprised.

Item 1 is the actionable part: remove the two imports, run the usual gates.

🤖 Generated with Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions