#5295: reject out-of-int-range numbers in Expect.Int and Expect.Natural

Author: morphqdd

eo-runtime/src/main/java/org/eolang/Expect.java

@@ -262,6 +262,8 @@ public Integer it() {
                 .otherwise("must be a number")
                 .must(number -> number % 1 == 0)
                 .otherwise("must be an integer")
+                .must(number -> number >= Integer.MIN_VALUE && number <= Integer.MAX_VALUE)
+                .otherwise("must fit into int range")
                 .that(Double::intValue)
                 .it();
         }
@@ -394,6 +396,8 @@ public Integer it() {
                 .otherwise("must be a number")
                 .must(number -> number % 1 == 0)
                 .otherwise("must be an integer")
+                .must(number -> number >= Integer.MIN_VALUE && number <= Integer.MAX_VALUE)
+                .otherwise("must fit into int range")
                 .that(Double::intValue)
                 .must(integer -> integer >= 0)
                 .otherwise("must be greater or equal to zero")

eo-runtime/src/test/java/org/eolang/ExpectTest.java

@@ -273,4 +273,50 @@ void failsInTransformingToNonNegativeIntegerForNegative() {
             Matchers.equalTo("the 'ρ' attribute (-42) must be greater or equal to zero")
         );
     }
+
+    @Test
+    void failsInTransformingToIntegerForTooLarge() {
+        MatcherAssert.assertThat(
+            "inner class Integer throws error for a number outside int range, "
+                + "instead of silently saturating via Double.intValue()",
+            Assertions.assertThrows(
+                ExFailure.class,
+                () -> new Expect.Int(
+                    Expect.at(
+                        new PhApplication(
+                            new PhDefault(),
+                            Phi.RHO,
+                            new Data.ToPhi(1.0e15)
+                        ),
+                        Phi.RHO
+                    )
+                ).it(),
+                "fails with correct error message while transform Phi to Integer"
+            ).getMessage(),
+            Matchers.equalTo("the 'ρ' attribute (1.0E15) must fit into int range")
+        );
+    }
+
+    @Test
+    void failsInTransformingToNonNegativeIntegerForTooLarge() {
+        MatcherAssert.assertThat(
+            "inner class NonNegativeInteger throws error for a number outside int range, "
+                + "instead of silently saturating via Double.intValue()",
+            Assertions.assertThrows(
+                ExFailure.class,
+                () -> new Expect.Natural(
+                    Expect.at(
+                        new PhApplication(
+                            new PhDefault(),
+                            Phi.RHO,
+                            new Data.ToPhi(1.0e15)
+                        ),
+                        Phi.RHO
+                    )
+                ).it(),
+                "fails with correct error message while transform Phi to NonNegativeInteger"
+            ).getMessage(),
+            Matchers.equalTo("the 'ρ' attribute (1.0E15) must fit into int range")
+        );
+    }
 }