Merge pull request #4903 from volodya-lombrozo/4884-qulice-upgrade

refactor(#4884): upgrade qulice to version 0.25.1 in `eo-runtime`

Author: yegor256

eo-runtime/pom.xml

@@ -385,6 +385,7 @@
           <plugin>
             <groupId>com.qulice</groupId>
             <artifactId>qulice-maven-plugin</artifactId>
+            <version>0.25.1</version>
             <configuration>
               <excludes>
                 <exclude>dependencies:org.eolang:eo-maven-plugin</exclude>

eo-runtime/src/main/java/EOorg/EOeolang/EObytes$EOslice.java

@@ -38,6 +38,7 @@ public final class EObytes$EOslice extends PhDefault implements Atom {
     }
 
     @Override
+    @SuppressWarnings("PMD.UnnecessaryLocalRule")
     public Phi lambda() {
         final int start = Expect.at(this, "start")
             .that(phi -> new Dataized(phi).asNumber())

eo-runtime/src/main/java/EOorg/EOeolang/EOerror.java

@@ -140,8 +140,10 @@ public Collection<String> messages() {
          * @param message New one
          * @return New list of them
          */
-        private static Collection<String> concat(final Collection<String> before,
-            final String message) {
+        private static Collection<String> concat(
+            final Collection<String> before,
+            final String message
+        ) {
             final Collection<String> list = new ArrayList<>(before.size() + 1);
             list.addAll(before);
             list.add(message);
@@ -161,11 +163,10 @@ private static String safeMessage(final Phi enclosure) {
                 result = "null Phi";
             } else {
                 try {
-                    final byte[] raw = new Dataized(enclosure).take();
                     result = String.format(
                         "%s(Δ = %s)",
                         enclosure,
-                        new VerboseBytesAsString(raw).get()
+                        new VerboseBytesAsString(new Dataized(enclosure).take()).get()
                     );
                 } catch (final Exception first) {
                     try {

eo-runtime/src/main/java/EOorg/EOeolang/EOfs/EOdir$EOwalk.java

@@ -42,17 +42,19 @@ public final class EOdir$EOwalk extends PhDefault implements Atom {
     }
 
     @Override
+    @SuppressWarnings("PMD.UnnecessaryLocalRule")
     public Phi lambda() {
         final Path path = Paths.get(
             new Dataized(
                 this.take(Phi.RHO).take("file").take("path")
             ).asString()
         ).toAbsolutePath();
-        final String glob = new Dataized(
-            this.take("glob")
-        ).asString();
         final PathMatcher matcher = FileSystems.getDefault().getPathMatcher(
-            String.format("glob:%s", glob)
+            String.format(
+                "glob:%s", new Dataized(
+                    this.take("glob")
+                ).asString()
+            )
         );
         try (Stream<Path> paths = Files.walk(path)) {
             return new Data.ToPhi(

eo-runtime/src/main/java/EOorg/EOeolang/EOfs/Files.java

@@ -23,7 +23,12 @@
 /**
  * File streams.
  * @since 0.40
+ * @todo #4884:30min Use ReentrantLock instead of 'synchronized' in Files.
+ *  We should use ReentrantLock instead of 'synchronized' to avoid potential
+ *  deadlocks when multiple AtOnce attributes are used together.
+ *  Moreover, 'synchronized' keyword is forbidden by qulice.
  */
+@SuppressWarnings("PMD.AvoidSynchronizedStatement")
 final class Files {
     /**
      * Files instance.
@@ -33,6 +38,7 @@ final class Files {
     /**
      * File input streams for reading.
      */
+    @SuppressWarnings("PMD.LooseCoupling")
     private final ConcurrentHashMap<String, Object[]> streams;
 
     /**
@@ -52,7 +58,7 @@ void open(final String name) throws IOException {
         final Path path = Paths.get(name);
         this.streams.putIfAbsent(
             name,
-            new Object[] {
+            new Object[]{
                 java.nio.file.Files.newInputStream(path),
                 java.nio.file.Files.newOutputStream(path, StandardOpenOption.APPEND),
             }

eo-runtime/src/main/java/EOorg/EOeolang/EOmalloc$EOof$EOallocated$EOresized.java

@@ -34,6 +34,7 @@ public final class EOmalloc$EOof$EOallocated$EOresized extends PhDefault impleme
     }
 
     @Override
+    @SuppressWarnings("PMD.UnnecessaryLocalRule")
     public Phi lambda() {
         final Phi rho = this.take(Phi.RHO);
         final int id = Expect.at(rho, "id")

eo-runtime/src/main/java/EOorg/EOeolang/EOms/EOpow.java

@@ -23,7 +23,6 @@
  * @checkstyle TypeNameCheck (100 lines)
  */
 @XmirObject(oname = "pow")
-@SuppressWarnings("PMD.AvoidDollarSigns")
 public final class EOpow extends PhDefault implements Atom {
     /**
      * Ctor.

eo-runtime/src/main/java/EOorg/EOeolang/EOnumber$EOdiv.java

@@ -35,6 +35,7 @@ public final class EOnumber$EOdiv extends PhDefault implements Atom {
     }
 
     @Override
+    @SuppressWarnings("PMD.UnnecessaryLocalRule")
     public Phi lambda() {
         final Double left = new Expect.Number(Expect.at(this, Phi.RHO)).it();
         final Double right = new Expect.Number(Expect.at(this, "x")).it();

eo-runtime/src/main/java/EOorg/EOeolang/EOnumber$EOgt.java

@@ -35,6 +35,7 @@ public final class EOnumber$EOgt extends PhDefault implements Atom {
     }
 
     @Override
+    @SuppressWarnings("PMD.UnnecessaryLocalRule")
     public Phi lambda() {
         final Double left = new Expect.Number(Expect.at(this, Phi.RHO)).it();
         final Double right = new Expect.Number(Expect.at(this, "x")).it();

eo-runtime/src/main/java/EOorg/EOeolang/EOnumber$EOplus.java

@@ -36,8 +36,11 @@ public final class EOnumber$EOplus extends PhDefault implements Atom {
 
     @Override
     public Phi lambda() {
-        final Double left = new Expect.Number(Expect.at(this, Phi.RHO)).it();
-        final Double right = new Expect.Number(Expect.at(this, "x")).it();
-        return new Data.ToPhi(Double.sum(left, right));
+        return new Data.ToPhi(
+            Double.sum(
+                new Expect.Number(Expect.at(this, Phi.RHO)).it(),
+                new Expect.Number(Expect.at(this, "x")).it()
+            )
+        );
     }
 }