feat(#4533): remove last $ usage from regex matched block#5240
Open
asmirnov-backend wants to merge 1 commit into
Open
feat(#4533): remove last $ usage from regex matched block#5240asmirnov-backend wants to merge 1 commit into
asmirnov-backend wants to merge 1 commit into
Conversation
…ch.matched Drop the `$ > matched` self-binding from `regex.eo`: route the recursion through `^` (the block's rho, which is `match`) and remove the now-redundant `.matched` accessor. No change to the Java atom or the parser. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Contributor
Author
|
@yegor256, could you please take a look |
Contributor
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
✅ Performance gain: |
Member
|
@asmirnov-backend let's wait with this PR until #5165 is resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4533 (runtime part).
regex.eo's$ > matchedwas the only remaining$(self/ξ) usage in the whole runtime library. Removed it by routing thenextrecursion through^(the block's ρ, which ismatch) and dropping the now-redundant.matchedaccessor — no Java atom or parser changes.The idempotency sugar the original
@todowaited on was dropped in the parser rewrite (769675b1a), so this approach uses no sugar at all.Parser-level grammar removal of
$is left as a follow-up.