feat(#5165): add Taken tuple object#5246
Draft
asmirnov-backend wants to merge 2 commits into
Draft
Conversation
The pair returned by `Phi.take(String)`: the object plus a flag telling whether it is pure and therefore may be memoized by `PhSticky`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
|
|
Contributor
Author
|
@yegor256, could you please take a look |
asmirnov-backend
changed the title
Taken tuple typeTaken tuple object
Open
Member
asmirnov-backend
marked this pull request as draft
June 27, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5165.
Adds
Taken, the pair thatPhi.take(String)will return: the taken object plus apure()flag telling whether it may be memoized.Unused for now — consumed when
Phi.takeadopts the new signature andPhStickyreadspure()to decide what to cache.