#5306: reject numbers outside long range in sprintf %d conversion instead of saturating#5316
Merged
yegor256 merged 1 commit intoJul 8, 2026
Conversation
…nversion instead of saturating
|
Contributor
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
✅ Performance gain: |
Contributor
Author
|
@yegor256, please take a look when you have a moment. |
|
@morphqdd Thanks for the contribution! You've earned +12 points for this: +16 as a basis; -4 for too few (28) hits-of-code. Please, keep them coming. Your running score is +548; don't forget to check your Zerocracy account too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #5306.
sprintf's%dconversion (SprintfArgs.CONVERSION.put('d', element -> element.asNumber().longValue()))narrowed the argument's
Doublevalue tolongviaDouble.longValue(), which doesn't throw fora value outside
longrange — it saturates, returningLong.MAX_VALUE/Long.MIN_VALUE. Sosprintf("%d", *1e30)silently printed9223372036854775807instead of raising a domain errornaming the offending value. This is the same
Double-to-integral narrowing-without-validationdefect already fixed for
Expect.Natural/Expect.Int(#5295/#5307) andnumber.as-i64(#5305/#5315), here in the
%dconversion path used by everysprintfcall in this codebase.Added a
SprintfArgs.toLong(double)helper that checks the value againstLong.MIN_VALUE/Long.MAX_VALUEbefore narrowing, and wired it into the'd'entry of theCONVERSIONmap inplace of the raw
.longValue()call.Added
throws-on-formatting-huge-number-as-decimaltott/sprintf.eo, using1.0e30— the exactreproduction value from the issue — mirroring the existing
truncates-*-as-decimaltests for the%dconversion.Ran the full EO-generated sprintf test suite locally (
EOtt.EOsprintfTest) — all 20 tests pass.