fix(#954): ignore auto-named objects in wrong-test-order#1033
Open
ext11n7 wants to merge 4 commits into
Open
Conversation
Contributor
Author
ext11n7
force-pushed
the
954-wrong-test-order
branch
from
0dae66e to
40beaa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #954.
The wrong-test-order lint currently inspects only the immediately following sibling after a test object. After �ars-float-up, anonymous helper objects can be appended to the end of the parent object with auto-generated names like �??18-4, which makes correctly placed tests look as if they are followed by a non-test object.
This patch skips those auto-named siblings when searching for the first meaningful object after a test. A regression test was added with a minimal XMIR document where +tests-filtered-with-bools is followed only by �??18-4; master reports a false positive there, while the patch keeps the defect list empty.