feat: implement dispatcher plugin for enhanced route management and deprecate legacy HttpDispatcher

Author: hotlong

packages/adapters/hono/src/index.ts

@@ -8,8 +8,22 @@ export interface ObjectStackHonoOptions {
 }
 
 /**
- * Creates a Hono application tailored for ObjectStack
- * Fully compliant with @objectstack/spec
+ * @deprecated Use `HonoServerPlugin` + `createRestApiPlugin()` + `createDispatcherPlugin()` instead.
+ * This function bundles all routes into a single Hono app using the legacy HttpDispatcher.
+ * The plugin-based approach provides better modularity and separation of concerns.
+ *
+ * Migration:
+ * ```ts
+ * // Before:
+ * const app = createHonoApp({ kernel, prefix: '/api/v1' });
+ *
+ * // After:
+ * import { createRestApiPlugin } from '@objectstack/rest';
+ * import { createDispatcherPlugin } from '@objectstack/runtime';
+ * kernel.use(new HonoServerPlugin({ port: 3000 }));
+ * kernel.use(createRestApiPlugin());
+ * kernel.use(createDispatcherPlugin({ prefix: '/api/v1' }));
+ * ```
  */
 export function createHonoApp(options: ObjectStackHonoOptions) {
   const app = new Hono();

packages/cli/src/commands/serve.ts

@@ -235,6 +235,15 @@ export const serveCommand = new Command('serve')
         } catch (e: any) {
           // @objectstack/rest is optional
         }
+
+        // Register Dispatcher plugin (auth, graphql, analytics, packages, hub, storage, automation)
+        try {
+          const { createDispatcherPlugin } = await import('@objectstack/runtime');
+          await kernel.use(createDispatcherPlugin());
+          trackPlugin('Dispatcher');
+        } catch (e: any) {
+          // optional
+        }
       }
 
       // ── Studio UI (--ui) ────────────────────────────────────────────

packages/plugins/plugin-hono-server/package.json

@@ -12,10 +12,7 @@
   "dependencies": {
     "@hono/node-server": "^1.2.0",
     "@objectstack/core": "workspace:*",
-    "@objectstack/hono": "workspace:*",
-    "@objectstack/runtime": "workspace:*",
     "@objectstack/spec": "workspace:*",
-    "@objectstack/types": "workspace:*",
     "hono": "^4.0.0"
   },
   "devDependencies": {

packages/plugins/plugin-hono-server/src/hono-plugin.test.ts

@@ -1,7 +1,6 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest';
 import { HonoServerPlugin } from './hono-plugin';
 import { PluginContext } from '@objectstack/core';
-import { createHonoApp } from '@objectstack/hono';
 import { HonoHttpServer } from './adapter';
 
 vi.mock('fs', async (importOriginal) => {
@@ -12,11 +11,6 @@ vi.mock('fs', async (importOriginal) => {
     };
 });
 
-// Mock dependencies
-vi.mock('@objectstack/hono', () => ({
-    createHonoApp: vi.fn(),
-}));
-
 vi.mock('@hono/node-server/serve-static', () => ({
     serveStatic: vi.fn(() => (c: any, next: any) => next())
 }));
@@ -64,10 +58,6 @@ describe('HonoServerPlugin', () => {
             hook: vi.fn(),
             getService: vi.fn()
         };
-
-        (createHonoApp as any).mockReturnValue({
-            // Mock Hono App structure if needed
-        });
     });
 
     it('should initialize and register server', async () => {
@@ -78,49 +68,28 @@ describe('HonoServerPlugin', () => {
         expect(HonoHttpServer).toHaveBeenCalled();
     });
 
-    it('should create and mount Hono app on start', async () => {
+    it('should register IHttpServer service on init', async () => {
         const plugin = new HonoServerPlugin();
         await plugin.init(context as PluginContext);
-        await plugin.start(context as PluginContext);
-        
-        expect(createHonoApp).toHaveBeenCalledWith(expect.objectContaining({
-            kernel: kernel,
-            prefix: '/api/v1'
-        }));
 
-        // Access the mocked server instance
-        const serverInstance = (HonoHttpServer as any).mock.instances[0];
-        expect(serverInstance.mount).toHaveBeenCalledWith('/', expect.anything());
+        expect(context.registerService).toHaveBeenCalledWith('http.server', expect.any(Object));
+        expect(context.registerService).toHaveBeenCalledWith('http-server', expect.any(Object));
     });
 
-    it('should respect REST server configuration for prefix', async () => {
-        const plugin = new HonoServerPlugin({
-            restConfig: {
-                api: {
-                    version: 'v2',
-                    basePath: '/custom'
-                }
-            }
-        });
-        
+    it('should start without errors', async () => {
+        const plugin = new HonoServerPlugin();
         await plugin.init(context as PluginContext);
         await plugin.start(context as PluginContext);
 
-        expect(createHonoApp).toHaveBeenCalledWith(expect.objectContaining({
-            prefix: '/custom/v2'
-        }));
+        // Plugin should register kernel:ready hook to start listening
+        expect(context.hook).toHaveBeenCalledWith('kernel:ready', expect.any(Function));
     });
 
-    it('should handle errors during app creation', async () => {
-        (createHonoApp as any).mockImplementation(() => {
-            throw new Error('Creation failed');
-        });
-
+    it('should handle errors gracefully on start', async () => {
+        // Simulate a start that doesn't crash even without routes
         const plugin = new HonoServerPlugin();
         await plugin.init(context as PluginContext);
-        await plugin.start(context as PluginContext);
-        
-        expect(logger.error).toHaveBeenCalledWith('Failed to create standard Hono app', expect.any(Error));
+        await expect(plugin.start(context as PluginContext)).resolves.not.toThrow();
     });
 
     it('should configure static files and SPA fallback when enabled', async () => {

packages/plugins/plugin-hono-server/src/hono-plugin.ts

@@ -1,13 +1,8 @@
-import { Plugin, PluginContext, IHttpServer, ApiRegistry } from '@objectstack/core';
-import { ObjectStackProtocol } from '@objectstack/spec/api';
-import { 
-    ApiRegistryEntryInput,
-    ApiEndpointRegistrationInput,
+import { Plugin, PluginContext, IHttpServer } from '@objectstack/core';
+import {
     RestServerConfig,
 } from '@objectstack/spec/api';
 import { HonoHttpServer } from './adapter';
-import { createHonoApp } from '@objectstack/hono';
-import { HttpDispatcher } from '@objectstack/runtime';
 import { serveStatic } from '@hono/node-server/serve-static';
 import * as fs from 'fs';
 import * as path from 'path';
@@ -54,7 +49,11 @@ export interface HonoPluginOptions {
  * Hono Server Plugin
  * 
  * Provides HTTP server capabilities using Hono framework.
- * Registers routes for ObjectStack Runtime Protocol.
+ * Registers the IHttpServer service so other plugins can register routes.
+ * 
+ * Route registration is handled by plugins:
+ * - `@objectstack/rest` → CRUD, metadata, discovery, UI, batch
+ * - `createDispatcherPlugin()` → auth, graphql, analytics, packages, etc.
  */
 export class HonoServerPlugin implements Plugin {
     name = 'com.objectstack.server.hono';
@@ -99,40 +98,10 @@ export class HonoServerPlugin implements Plugin {
     }
 
     /**
-     * Start phase - Bind routes and start listening
+     * Start phase - Configure static files and start listening
      */
     start = async (ctx: PluginContext) => {
         ctx.logger.debug('Starting Hono server plugin');
-        
-        // Use Standard ObjectStack Runtime Hono App
-        try {
-            const kernel = ctx.getKernel();
-            const config = this.options.restConfig || {};
-            // Calculate prefix similar to before
-            const apiVersion = config.api?.version || 'v1';
-            const basePath = config.api?.basePath || '/api';
-            const apiPath = config.api?.apiPath || `${basePath}/${apiVersion}`;
-            
-            const app = createHonoApp({ 
-                kernel,
-                prefix: apiPath // Use the calculated path
-            });
-            
-            ctx.logger.debug('Mounting ObjectStack Runtime App', { prefix: apiPath });
-            // Use the mount method we added to HonoHttpServer
-            this.server.mount('/', app as any);
-
-            // Register Standard Discovery Endpoint
-            const rawApp = this.server.getRawApp();
-            const dispatcher = new HttpDispatcher(kernel);
-            rawApp.get('/.well-known/objectstack', (c) => {
-                return c.json({ data: dispatcher.getDiscoveryInfo(apiPath) });
-            });
-            ctx.logger.debug('Registered standard discovery endpoint', { path: '/.well-known/objectstack', target: apiPath });
-
-        } catch (e: any) {
-             ctx.logger.error('Failed to create standard Hono app', e);
-        }
 
         // Configure Static Files & SPA Fallback
         const mounts: StaticMount[] = this.options.staticMounts || [];