Merge pull request #409 from objectstack-ai/copilot/fix-action-step-error-another-one

Author: hotlong

packages/spec/src/ai/conversation.test.ts

@@ -504,7 +504,7 @@ describe('Real-World Conversation Examples', () => {
           timestamp: '2024-01-15T09:00:05Z',
           role: 'user',
           content: 'Hi, I have an issue with my order #ORD-2024-001',
-          tokens: { prompt: 15, total: 15 },
+          tokens: { prompt: 15, completion: 0, total: 15 },
         },
         {
           id: 'msg-2',

packages/spec/src/auth/config.test.ts

@@ -472,7 +472,7 @@ describe('EnterpriseAuthConfigSchema', () => {
       },
     };
 
-    expect(() => EnterpriseApplicationAuthConfigSchema.parse(config)).not.toThrow();
+    expect(() => EnterpriseAuthConfigSchema.parse(config)).not.toThrow();
   });
 
   it('should accept partial enterprise config', () => {
@@ -485,12 +485,12 @@ describe('EnterpriseAuthConfigSchema', () => {
       },
     };
 
-    expect(() => EnterpriseApplicationAuthConfigSchema.parse(config)).not.toThrow();
+    expect(() => EnterpriseAuthConfigSchema.parse(config)).not.toThrow();
   });
 
   it('should accept empty enterprise config', () => {
     const config = {};
-    expect(() => EnterpriseApplicationAuthConfigSchema.parse(config)).not.toThrow();
+    expect(() => EnterpriseAuthConfigSchema.parse(config)).not.toThrow();
   });
 });
 

packages/spec/src/automation/workflow.test.ts

@@ -471,7 +471,10 @@ describe('WorkflowActionSchema', () => {
     const action = {
       name: 'trigger_webhook',
       type: 'webhook_trigger' as const,
-      url: 'https://webhook.example.com',
+      config: {
+        name: 'test_webhook',
+        url: 'https://webhook.example.com',
+      },
     };
 
     expect(() => WorkflowActionSchema.parse(action)).not.toThrow();

packages/spec/src/data/external-lookup.test.ts

@@ -121,8 +121,8 @@ describe('ExternalDataSourceSchema', () => {
 describe('FieldMappingSchema', () => {
   it('should validate complete field mapping', () => {
     const validMapping: FieldMapping = {
-      externalField: 'AccountName',
-      localField: 'name',
+      source: 'AccountName',
+      target: 'name',
       type: 'text',
       readonly: true,
     };
@@ -132,8 +132,8 @@ describe('FieldMappingSchema', () => {
 
   it('should accept minimal field mapping', () => {
     const minimalMapping = {
-      externalField: 'ExternalField',
-      localField: 'local_field',
+      source: 'ExternalField',
+      target: 'local_field',
       type: 'text',
     };
 
@@ -142,8 +142,8 @@ describe('FieldMappingSchema', () => {
 
   it('should default readonly to true', () => {
     const mapping = {
-      externalField: 'Field1',
-      localField: 'field_1',
+      source: 'Field1',
+      target: 'field_1',
       type: 'text',
     };
 
@@ -153,8 +153,8 @@ describe('FieldMappingSchema', () => {
 
   it('should accept writable field mapping', () => {
     const writableMapping = {
-      externalField: 'Status',
-      localField: 'status',
+      source: 'Status',
+      target: 'status',
       type: 'text',
       readonly: false,
     };
@@ -167,8 +167,8 @@ describe('FieldMappingSchema', () => {
 
     types.forEach((type) => {
       const mapping = {
-        externalField: 'Field',
-        localField: 'field',
+        source: 'Field',
+        target: 'field',
         type,
       };
 
@@ -198,14 +198,14 @@ describe('ExternalLookupSchema', () => {
       },
       fieldMappings: [
         {
-          externalField: 'Name',
-          localField: 'account_name',
+          source: 'Name',
+          target: 'account_name',
           type: 'text',
           readonly: true,
         },
         {
-          externalField: 'Industry',
-          localField: 'industry',
+          source: 'Industry',
+          target: 'industry',
           type: 'text',
           readonly: true,
         },
@@ -246,8 +246,8 @@ describe('ExternalLookupSchema', () => {
       },
       fieldMappings: [
         {
-          externalField: 'Field1',
-          localField: 'field_1',
+          source: 'Field1',
+          target: 'field_1',
           type: 'text',
         },
       ],
@@ -516,20 +516,20 @@ describe('ExternalLookupSchema', () => {
       },
       fieldMappings: [
         {
-          externalField: 'ProductID',
-          localField: 'product_id',
+          source: 'ProductID',
+          target: 'product_id',
           type: 'number',
           readonly: true,
         },
         {
-          externalField: 'ProductName',
-          localField: 'product_name',
+          source: 'ProductName',
+          target: 'product_name',
           type: 'text',
           readonly: true,
         },
         {
-          externalField: 'UnitPrice',
-          localField: 'unit_price',
+          source: 'UnitPrice',
+          target: 'unit_price',
           type: 'currency',
           readonly: true,
         },
@@ -564,20 +564,20 @@ describe('ExternalLookupSchema', () => {
       },
       fieldMappings: [
         {
-          externalField: 'id',
-          localField: 'user_id',
+          source: 'id',
+          target: 'user_id',
           type: 'text',
           readonly: true,
         },
         {
-          externalField: 'name',
-          localField: 'user_name',
+          source: 'name',
+          target: 'user_name',
           type: 'text',
           readonly: true,
         },
         {
-          externalField: 'email',
-          localField: 'user_email',
+          source: 'email',
+          target: 'user_email',
           type: 'email',
           readonly: true,
         },
@@ -619,26 +619,26 @@ describe('ExternalLookupSchema', () => {
       },
       fieldMappings: [
         {
-          externalField: 'Id',
-          localField: 'salesforce_id',
+          source: 'Id',
+          target: 'salesforce_id',
           type: 'text',
           readonly: true,
         },
         {
-          externalField: 'Name',
-          localField: 'contact_name',
+          source: 'Name',
+          target: 'contact_name',
           type: 'text',
           readonly: true,
         },
         {
-          externalField: 'Email',
-          localField: 'email',
+          source: 'Email',
+          target: 'email',
           type: 'email',
           readonly: true,
         },
         {
-          externalField: 'Phone',
-          localField: 'phone',
+          source: 'Phone',
+          target: 'phone',
           type: 'phone',
           readonly: true,
         },

packages/spec/src/integration/connector.test.ts

@@ -120,17 +120,18 @@ describe('OAuth2Schema', () => {
     expect(parsed.refreshToken).toBe('refresh-token-xyz');
   });
 
-  it('should use default grant type', () => {
+  it('should accept OAuth2 without optional fields', () => {
     const auth = {
-      type: 'oauth2',
+      type: 'oauth2' as const,
       clientId: 'client-id',
       clientSecret: 'client-secret',
       authorizationUrl: 'https://auth.example.com/authorize',
       tokenUrl: 'https://auth.example.com/token',
     };
 
     const parsed = OAuth2Schema.parse(auth);
-    expect(parsed.grantType).toBe('authorization_code');
+    expect(parsed.type).toBe('oauth2');
+    expect(parsed.clientId).toBe('client-id');
   });
 });
 
@@ -226,44 +227,33 @@ describe('AuthenticationSchema', () => {
 describe('FieldMappingSchema', () => {
   it('should accept valid field mapping', () => {
     const mapping: FieldMapping = {
-      sourceField: 'firstName',
-      targetField: 'first_name',
+      source: 'firstName',
+      target: 'first_name',
       dataType: 'string',
       syncMode: 'bidirectional',
     };
 
     expect(() => FieldMappingSchema.parse(mapping)).not.toThrow();
   });
 
-  it('should validate target field snake_case format', () => {
-    expect(() => FieldMappingSchema.parse({
-      sourceField: 'field',
-      targetField: 'valid_field_name',
-    })).not.toThrow();
-    
-    expect(() => FieldMappingSchema.parse({
-      sourceField: 'field',
-      targetField: 'InvalidField',
-    })).toThrow();
-  });
-  
   it('should accept field with transformation', () => {
     const mapping = {
-      sourceField: 'name',
-      targetField: 'full_name',
+      source: 'name',
+      target: 'full_name',
       transform: {
-        type: 'uppercase',
+        type: 'javascript' as const,
+        expression: 'value.toUpperCase()',
       },
     };
 
     const parsed = FieldMappingSchema.parse(mapping);
-    expect(parsed.transform?.type).toBe('uppercase');
+    expect(parsed.transform?.type).toBe('javascript');
   });
 
   it('should use default values', () => {
     const mapping = {
-      sourceField: 'field1',
-      targetField: 'field_1',
+      source: 'field1',
+      target: 'field_1',
     };
 
     const parsed = FieldMappingSchema.parse(mapping);
@@ -317,41 +307,42 @@ describe('DataSyncConfigSchema', () => {
 describe('WebhookConfigSchema', () => {
   it('should accept valid webhook configuration', () => {
     const webhook: WebhookConfig = {
+      name: 'test_webhook',
       url: 'https://api.example.com/webhooks',
       events: ['record.created', 'record.updated'],
       secret: 'webhook-secret',
       signatureAlgorithm: 'hmac_sha256',
-      enabled: true,
     };
 
     expect(() => WebhookConfigSchema.parse(webhook)).not.toThrow();
   });
 
   it('should accept webhook with retry configuration', () => {
     const webhook = {
+      name: 'retry_webhook',
       url: 'https://api.example.com/webhooks',
       events: ['sync.completed'],
-      retryConfig: {
-        maxAttempts: 3,
-        backoffMultiplier: 2,
+      retryPolicy: {
+        maxRetries: 3,
+        backoffStrategy: 'exponential' as const,
         initialDelayMs: 1000,
       },
     };
 
     const parsed = WebhookConfigSchema.parse(webhook);
-    expect(parsed.retryConfig?.maxAttempts).toBe(3);
+    expect(parsed.retryPolicy?.maxRetries).toBe(3);
   });
 
   it('should use default values', () => {
     const webhook = {
+      name: 'default_webhook',
       url: 'https://api.example.com/webhooks',
       events: ['record.created'],
     };
 
     const parsed = WebhookConfigSchema.parse(webhook);
     expect(parsed.signatureAlgorithm).toBe('hmac_sha256');
     expect(parsed.timeoutMs).toBe(30000);
-    expect(parsed.enabled).toBe(true);
   });
 });
 
@@ -478,12 +469,13 @@ describe('ConnectorSchema', () => {
       },
       fieldMappings: [
         {
-          sourceField: 'id',
-          targetField: 'external_id',
+          source: 'id',
+          target: 'external_id',
         },
       ],
       webhooks: [
         {
+          name: 'connector_webhook',
           url: 'https://api.example.com/webhook',
           events: ['record.created'],
         },
@@ -602,14 +594,14 @@ describe('Connector Integration', () => {
       },
       fieldMappings: [
         {
-          sourceField: 'FirstName',
-          targetField: 'first_name',
+          source: 'FirstName',
+          target: 'first_name',
           dataType: 'string',
           required: true,
         },
         {
-          sourceField: 'LastName',
-          targetField: 'last_name',
+          source: 'LastName',
+          target: 'last_name',
           dataType: 'string',
           required: true,
         },