refactor(metadata): update MetadataProjector to use a scope object for organization and environment IDs

test: add localStorage shim for consistent testing behavior across environments

Author: hotlong

apps/studio/test/ai-chat-panel.test.tsx

@@ -97,10 +97,10 @@ describe('use-ai-chat-panel', () => {
     });
 
     it('does not throw when localStorage is unavailable', () => {
-      const originalSetItem = Storage.prototype.setItem;
-      Storage.prototype.setItem = () => { throw new Error('QuotaExceeded'); };
+      const originalSetItem = localStorage.setItem.bind(localStorage);
+      localStorage.setItem = () => { throw new Error('QuotaExceeded'); };
       expect(() => saveMessages([makeMsg({ id: '1', role: 'user', content: 'A' })])).not.toThrow();
-      Storage.prototype.setItem = originalSetItem;
+      localStorage.setItem = originalSetItem;
     });
   });
 });
@@ -260,10 +260,10 @@ describe('Agent Selector', () => {
     });
 
     it('should not throw when localStorage is unavailable', () => {
-      const originalSetItem = Storage.prototype.setItem;
-      Storage.prototype.setItem = () => { throw new Error('QuotaExceeded'); };
+      const originalSetItem = localStorage.setItem.bind(localStorage);
+      localStorage.setItem = () => { throw new Error('QuotaExceeded'); };
       expect(() => saveSelectedAgent('metadata_assistant')).not.toThrow();
-      Storage.prototype.setItem = originalSetItem;
+      localStorage.setItem = originalSetItem;
     });
   });
 

apps/studio/test/setup.ts

@@ -7,7 +7,55 @@
 
 import '@testing-library/jest-dom/vitest';
 import { cleanup } from '@testing-library/react';
-import { afterEach } from 'vitest';
+import { afterEach, beforeEach } from 'vitest';
+
+// Node 22+ ships an experimental built-in `localStorage` that is a plain
+// empty object without Storage API methods. When `@vitest-environment
+// happy-dom` runs, that global can shadow happy-dom's Storage implementation,
+// leaving tests with `localStorage.getItem is not a function`. Install a
+// minimal in-memory Storage-compatible shim to guarantee consistent behavior
+// across Node versions and environments.
+function installStorageShim(): void {
+  const store = new Map<string, string>();
+  const shim = {
+    get length() {
+      return store.size;
+    },
+    clear(): void {
+      store.clear();
+    },
+    getItem(key: string): string | null {
+      return store.has(key) ? (store.get(key) as string) : null;
+    },
+    setItem(key: string, value: string): void {
+      store.set(String(key), String(value));
+    },
+    removeItem(key: string): void {
+      store.delete(key);
+    },
+    key(index: number): string | null {
+      return Array.from(store.keys())[index] ?? null;
+    },
+  };
+  Object.defineProperty(globalThis, 'localStorage', {
+    configurable: true,
+    writable: true,
+    value: shim,
+  });
+  Object.defineProperty(globalThis, 'sessionStorage', {
+    configurable: true,
+    writable: true,
+    value: { ...shim },
+  });
+}
+
+installStorageShim();
+
+// Re-install before each test so tests that mutate localStorage.setItem
+// (to simulate quota errors) cannot leak across other tests.
+beforeEach(() => {
+  installStorageShim();
+});
 
 // Cleanup after each test
 afterEach(() => {

packages/metadata/src/projection/metadata-projector.ts

@@ -38,8 +38,8 @@ export interface MetadataProjectorOptions {
 export class MetadataProjector {
   private driver?: IDataDriver;
   private engine?: IDataEngine;
-  private organizationId?: string;
-  private environmentId?: string;
+  /** Reserved for future multi-tenant projection scoping */
+  readonly scope: { organizationId?: string; environmentId?: string };
 
   // Map of metadata types to their target table names
   private readonly typeTableMap: Record<string, string> = {
@@ -57,8 +57,10 @@ export class MetadataProjector {
     }
     this.driver = options.driver;
     this.engine = options.engine;
-    this.organizationId = options.organizationId;
-    this.environmentId = options.environmentId;
+    this.scope = {
+      organizationId: options.organizationId,
+      environmentId: options.environmentId,
+    };
   }
 
   /**