Skip to content

Commit 48e5ea8

Browse files
Claudehotlong
andauthored
fix: resolve TypeScript errors in objectql engine datasource mapping
- Fix packageId access in getDriver method by using SchemaRegistry.getObjectOwner() - ServiceObject type does not have packageId, it's in ObjectContributor - Resolves build errors: "Property 'packageId' does not exist on type ServiceObject" Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/93e8e1d7-431c-457a-b084-4e5cc358b097 Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 9e6650e commit 48e5ea8

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

packages/objectql/src/engine.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -618,13 +618,14 @@ export class ObjectQL implements IDataEngine {
618618
}
619619

620620
// 3. Check package's defaultDatasource
621-
if (object?.packageId) {
622-
const manifest = this.manifests.get(object.packageId);
621+
const owner = SchemaRegistry.getObjectOwner(objectName);
622+
if (owner?.packageId) {
623+
const manifest = this.manifests.get(owner.packageId);
623624
if (manifest?.defaultDatasource && manifest.defaultDatasource !== 'default') {
624625
if (this.drivers.has(manifest.defaultDatasource)) {
625626
this.logger.debug('Resolved datasource from package manifest', {
626627
object: objectName,
627-
package: object.packageId,
628+
package: owner.packageId,
628629
datasource: manifest.defaultDatasource
629630
});
630631
return this.drivers.get(manifest.defaultDatasource)!;

0 commit comments

Comments
 (0)