refactor: remove non-standard types and align code with schema protocol

Copilot · hotlong · Copilot · commit 8792d006c2e1 · 2026-01-27T03:33:28.000Z
Co-authored-by: hotlong &lt;50353452+hotlong@users.noreply.github.com&gt;
diff --git a/content/docs/references/data/field/Field.mdx b/content/docs/references/data/field/Field.mdx
@@ -9,7 +9,7 @@ description: Field Schema Reference
 | :--- | :--- | :--- | :--- |
 | **name** | `string` | optional | Machine name (snake_case) |
 | **label** | `string` | optional | Human readable label |
-| **type** | `Enum<'text' \| 'textarea' \| 'email' \| 'url' \| 'phone' \| 'password' \| 'markdown' \| 'html' \| 'richtext' \| 'number' \| 'currency' \| 'percent' \| 'date' \| 'datetime' \| 'time' \| 'boolean' \| 'toggle' \| 'select' \| 'multiselect' \| 'radio' \| 'checkboxes' \| 'lookup' \| 'master_detail' \| 'tree' \| 'image' \| 'file' \| 'avatar' \| 'video' \| 'audio' \| 'formula' \| 'summary' \| 'autonumber' \| 'location' \| 'geolocation' \| 'address' \| 'code' \| 'json' \| 'color' \| 'rating' \| 'slider' \| 'signature' \| 'qrcode' \| 'progress' \| 'tags'>` | ✅ | Field Data Type |
+| **type** | `Enum<'text' \| 'textarea' \| 'email' \| 'url' \| 'phone' \| 'password' \| 'markdown' \| 'html' \| 'richtext' \| 'number' \| 'currency' \| 'percent' \| 'date' \| 'datetime' \| 'time' \| 'boolean' \| 'toggle' \| 'select' \| 'multiselect' \| 'radio' \| 'checkboxes' \| 'lookup' \| 'master_detail' \| 'tree' \| 'image' \| 'file' \| 'avatar' \| 'video' \| 'audio' \| 'formula' \| 'summary' \| 'autonumber' \| 'location' \| 'address' \| 'code' \| 'json' \| 'color' \| 'rating' \| 'slider' \| 'signature' \| 'qrcode' \| 'progress' \| 'tags'>` | ✅ | Field Data Type |
 | **description** | `string` | optional | Tooltip/Help text |
 | **format** | `string` | optional | Format string (e.g. email, phone) |
 | **required** | `boolean` | optional | Is required |
diff --git a/content/docs/references/data/field/FieldType.mdx b/content/docs/references/data/field/FieldType.mdx
@@ -38,7 +38,6 @@ description: FieldType Schema Reference
 * `summary`
 * `autonumber`
 * `location`
-* `geolocation`
 * `address`
 * `code`
 * `json`
diff --git a/content/docs/references/ui/action/ActionParam.mdx b/content/docs/references/ui/action/ActionParam.mdx
@@ -9,6 +9,6 @@ description: ActionParam Schema Reference
 | :--- | :--- | :--- | :--- |
 | **name** | `string` | ✅ |  |
 | **label** | `string` | ✅ |  |
-| **type** | `Enum<'text' \| 'textarea' \| 'email' \| 'url' \| 'phone' \| 'password' \| 'markdown' \| 'html' \| 'richtext' \| 'number' \| 'currency' \| 'percent' \| 'date' \| 'datetime' \| 'time' \| 'boolean' \| 'toggle' \| 'select' \| 'multiselect' \| 'radio' \| 'checkboxes' \| 'lookup' \| 'master_detail' \| 'tree' \| 'image' \| 'file' \| 'avatar' \| 'video' \| 'audio' \| 'formula' \| 'summary' \| 'autonumber' \| 'location' \| 'geolocation' \| 'address' \| 'code' \| 'json' \| 'color' \| 'rating' \| 'slider' \| 'signature' \| 'qrcode' \| 'progress' \| 'tags'>` | ✅ |  |
+| **type** | `Enum<'text' \| 'textarea' \| 'email' \| 'url' \| 'phone' \| 'password' \| 'markdown' \| 'html' \| 'richtext' \| 'number' \| 'currency' \| 'percent' \| 'date' \| 'datetime' \| 'time' \| 'boolean' \| 'toggle' \| 'select' \| 'multiselect' \| 'radio' \| 'checkboxes' \| 'lookup' \| 'master_detail' \| 'tree' \| 'image' \| 'file' \| 'avatar' \| 'video' \| 'audio' \| 'formula' \| 'summary' \| 'autonumber' \| 'location' \| 'address' \| 'code' \| 'json' \| 'color' \| 'rating' \| 'slider' \| 'signature' \| 'qrcode' \| 'progress' \| 'tags'>` | ✅ |  |
 | **required** | `boolean` | optional |  |
 | **options** | `object[]` | optional |  |
diff --git a/content/docs/references/ui/dashboard/ChartType.mdx b/content/docs/references/ui/dashboard/ChartType.mdx
@@ -9,7 +9,6 @@ description: ChartType Schema Reference
 * `bar`
 * `line`
 * `pie`
-* `donut`
 * `funnel`
 * `radar`
 * `scatter`
diff --git a/content/docs/references/ui/dashboard/DashboardWidget.mdx b/content/docs/references/ui/dashboard/DashboardWidget.mdx
@@ -8,7 +8,7 @@ description: DashboardWidget Schema Reference
 | Property | Type | Required | Description |
 | :--- | :--- | :--- | :--- |
 | **title** | `string` | optional | Widget title |
-| **type** | `Enum<'metric' \| 'bar' \| 'line' \| 'pie' \| 'donut' \| 'funnel' \| 'radar' \| 'scatter' \| 'heatmap' \| 'pivot' \| 'table' \| 'list' \| 'text' \| 'image' \| 'frame'>` | optional | Visualization type |
+| **type** | `Enum<'metric' \| 'bar' \| 'line' \| 'pie' \| 'funnel' \| 'radar' \| 'scatter' \| 'heatmap' \| 'pivot' \| 'table' \| 'list' \| 'text' \| 'image' \| 'frame'>` | optional | Visualization type |
 | **object** | `string` | optional | Data source object name |
 | **filter** | `any` | optional | Data filter criteria |
 | **categoryField** | `string` | optional | Field for grouping (X-Axis) |
diff --git a/examples/crm/src/ui/dashboards.ts b/examples/crm/src/ui/dashboards.ts
@@ -198,7 +198,7 @@ export const ServiceDashboard: Dashboard = {
     // Row 2: Case Distribution
     {
       title: 'Cases by Status',
-      type: 'donut',
+      type: 'pie',
       object: 'case',
       filter: { is_closed: false },
       categoryField: 'status',
diff --git a/packages/spec/json-schema/data/Field.json b/packages/spec/json-schema/data/Field.json
@@ -49,7 +49,6 @@
             "summary",
             "autonumber",
             "location",
-            "geolocation",
             "address",
             "code",
             "json",
diff --git a/packages/spec/json-schema/data/FieldType.json b/packages/spec/json-schema/data/FieldType.json
@@ -37,7 +37,6 @@
         "summary",
         "autonumber",
         "location",
-        "geolocation",
         "address",
         "code",
         "json",
diff --git a/packages/spec/json-schema/data/Object.json b/packages/spec/json-schema/data/Object.json
@@ -106,7 +106,6 @@
                   "summary",
                   "autonumber",
                   "location",
-                  "geolocation",
                   "address",
                   "code",
                   "json",
diff --git a/packages/spec/json-schema/ui/Action.json b/packages/spec/json-schema/ui/Action.json
@@ -111,7 +111,6 @@
                   "summary",
                   "autonumber",
                   "location",
-                  "geolocation",
                   "address",
                   "code",
                   "json",
diff --git a/packages/spec/json-schema/ui/ActionParam.json b/packages/spec/json-schema/ui/ActionParam.json
@@ -46,7 +46,6 @@
             "summary",
             "autonumber",
             "location",
-            "geolocation",
             "address",
             "code",
             "json",
diff --git a/packages/spec/json-schema/ui/ChartType.json b/packages/spec/json-schema/ui/ChartType.json
@@ -8,7 +8,6 @@
         "bar",
         "line",
         "pie",
-        "donut",
         "funnel",
         "radar",
         "scatter",
diff --git a/packages/spec/json-schema/ui/Dashboard.json b/packages/spec/json-schema/ui/Dashboard.json
@@ -33,7 +33,6 @@
                   "bar",
                   "line",
                   "pie",
-                  "donut",
                   "funnel",
                   "radar",
                   "scatter",
diff --git a/packages/spec/json-schema/ui/DashboardWidget.json b/packages/spec/json-schema/ui/DashboardWidget.json
@@ -15,7 +15,6 @@
             "bar",
             "line",
             "pie",
-            "donut",
             "funnel",
             "radar",
             "scatter",
diff --git a/packages/spec/json-schema/ui/FieldWidgetProps.json b/packages/spec/json-schema/ui/FieldWidgetProps.json
@@ -69,7 +69,6 @@
                 "summary",
                 "autonumber",
                 "location",
-                "geolocation",
                 "address",
                 "code",
                 "json",
diff --git a/packages/spec/src/data/field.test.ts b/packages/spec/src/data/field.test.ts
@@ -23,7 +23,7 @@ describe('FieldType', () => {
       'lookup', 'master_detail',
       'image', 'file', 'avatar',
       'formula', 'summary', 'autonumber',
-      'location', 'geolocation', 'address', 'code', 'color', 'rating', 'slider', 'signature', 'qrcode'
+      'location', 'address', 'code', 'color', 'rating', 'slider', 'signature', 'qrcode'
     ];
 
     validTypes.forEach(type => {
@@ -495,10 +495,6 @@ describe('Field Factory Helpers', () => {
       expect(() => FieldType.parse('location')).not.toThrow();
     });
 
-    it('should accept geolocation field type', () => {
-      expect(() => FieldType.parse('geolocation')).not.toThrow();
-    });
-
     it('should accept address field type', () => {
       expect(() => FieldType.parse('address')).not.toThrow();
     });
@@ -647,19 +643,6 @@ describe('Field Factory Helpers', () => {
       expect(qrcodeField.displayValue).toBe(true);
       expect(qrcodeField.allowScanning).toBe(true);
     });
-
-    it('should create geolocation field', () => {
-      const geolocationField = Field.geolocation({
-        label: 'Current Location',
-        displayMap: true,
-        allowGeocoding: false,
-      });
-      
-      expect(geolocationField.type).toBe('geolocation');
-      expect(geolocationField.label).toBe('Current Location');
-      expect(geolocationField.displayMap).toBe(true);
-      expect(geolocationField.allowGeocoding).toBe(false);
-    });
   });
 
   describe('Currency Field Type with Multi-Currency Support', () => {
diff --git a/packages/spec/src/data/field.zod.ts b/packages/spec/src/data/field.zod.ts
@@ -29,7 +29,6 @@ export const FieldType = z.enum([
   'formula', 'summary', 'autonumber',
   // Enhanced Types
   'location',     // GPS coordinates
-  'geolocation',  // GPS coordinates (alias for location)
   'address',      // Structured address
   'code',         // Code editor (JSON/SQL/JS)
   'json',         // Structured JSON data
@@ -364,9 +363,4 @@ export const Field = {
     type: 'qrcode', 
     ...config 
   } as const),
-  
-  geolocation: (config: FieldInput = {}) => ({ 
-    type: 'geolocation', 
-    ...config 
-  } as const),
 };
diff --git a/packages/spec/src/ui/dashboard.test.ts b/packages/spec/src/ui/dashboard.test.ts
@@ -10,7 +10,7 @@ import {
 
 describe('ChartType', () => {
   it('should accept all chart types', () => {
-    const types = ['metric', 'bar', 'line', 'pie', 'donut', 'funnel', 'table', 'text'];
+    const types = ['metric', 'bar', 'line', 'pie', 'funnel', 'table', 'text'];
     
     types.forEach(type => {
       expect(() => ChartType.parse(type)).not.toThrow();
@@ -255,7 +255,7 @@ describe('DashboardSchema', () => {
           },
           {
             title: 'Opportunities by Type',
-            type: 'donut',
+            type: 'pie',
             object: 'opportunity',
             categoryField: 'type',
             aggregate: 'count',
diff --git a/packages/spec/src/ui/dashboard.zod.ts b/packages/spec/src/ui/dashboard.zod.ts
@@ -9,8 +9,7 @@ export const ChartType = z.enum([
   'metric',    // KPI / Big Number
   'bar',       // Bar / Column
   'line',      // Line / Area
-  'pie',       // Pie Chart
-  'donut',     // Donut Chart
+  'pie',       // Pie / Donut
   'funnel',    // Conversion Funnel
   'radar',     // Spider / Radar
   'scatter',   // Scatter Plot

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ export const ServiceDashboard: Dashboard = {`
`198`	`198`	`// Row 2: Case Distribution`
`199`	`199`	`{`
`200`	`200`	`title: 'Cases by Status',`
`201`		`- type: 'donut',`
	`201`	`+ type: 'pie',`
`202`	`202`	`object: 'case',`
`203`	`203`	`filter: { is_closed: false },`
`204`	`204`	`categoryField: 'status',`