Skip to content

Commit 889f6a7

Browse files
authored
Merge pull request #286 from objectstack-ai/copilot/fix-action-step-error
2 parents d27a9d0 + 8792d00 commit 889f6a7

File tree

4 files changed

+5
-27
lines changed

4 files changed

+5
-27
lines changed

examples/crm/src/ui/dashboards.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ export const ServiceDashboard: Dashboard = {
198198
// Row 2: Case Distribution
199199
{
200200
title: 'Cases by Status',
201-
type: 'donut',
201+
type: 'pie',
202202
object: 'case',
203203
filter: { is_closed: false },
204204
categoryField: 'status',

packages/spec/src/data/field.test.ts

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe('FieldType', () => {
2323
'lookup', 'master_detail',
2424
'image', 'file', 'avatar',
2525
'formula', 'summary', 'autonumber',
26-
'location', 'geolocation', 'address', 'code', 'color', 'rating', 'slider', 'signature', 'qrcode'
26+
'location', 'address', 'code', 'color', 'rating', 'slider', 'signature', 'qrcode'
2727
];
2828

2929
validTypes.forEach(type => {
@@ -495,10 +495,6 @@ describe('Field Factory Helpers', () => {
495495
expect(() => FieldType.parse('location')).not.toThrow();
496496
});
497497

498-
it('should accept geolocation field type', () => {
499-
expect(() => FieldType.parse('geolocation')).not.toThrow();
500-
});
501-
502498
it('should accept address field type', () => {
503499
expect(() => FieldType.parse('address')).not.toThrow();
504500
});
@@ -647,19 +643,6 @@ describe('Field Factory Helpers', () => {
647643
expect(qrcodeField.displayValue).toBe(true);
648644
expect(qrcodeField.allowScanning).toBe(true);
649645
});
650-
651-
it('should create geolocation field', () => {
652-
const geolocationField = Field.geolocation({
653-
label: 'Current Location',
654-
displayMap: true,
655-
allowGeocoding: false,
656-
});
657-
658-
expect(geolocationField.type).toBe('geolocation');
659-
expect(geolocationField.label).toBe('Current Location');
660-
expect(geolocationField.displayMap).toBe(true);
661-
expect(geolocationField.allowGeocoding).toBe(false);
662-
});
663646
});
664647

665648
describe('Currency Field Type with Multi-Currency Support', () => {

packages/spec/src/data/field.zod.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -363,9 +363,4 @@ export const Field = {
363363
type: 'qrcode',
364364
...config
365365
} as const),
366-
367-
geolocation: (config: FieldInput = {}) => ({
368-
type: 'geolocation',
369-
...config
370-
} as const),
371366
};

packages/spec/src/ui/dashboard.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ import {
1010

1111
describe('ChartType', () => {
1212
it('should accept all chart types', () => {
13-
const types = ['metric', 'bar', 'line', 'pie', 'donut', 'funnel', 'table', 'text'];
13+
const types = ['metric', 'bar', 'line', 'pie', 'funnel', 'table', 'text'];
1414

1515
types.forEach(type => {
1616
expect(() => ChartType.parse(type)).not.toThrow();
1717
});
1818
});
1919

2020
it('should reject invalid chart types', () => {
21-
expect(() => ChartType.parse('scatter')).toThrow();
21+
expect(() => ChartType.parse('bubble')).toThrow();
2222
expect(() => ChartType.parse('invalid')).toThrow();
2323
});
2424
});
@@ -255,7 +255,7 @@ describe('DashboardSchema', () => {
255255
},
256256
{
257257
title: 'Opportunities by Type',
258-
type: 'donut',
258+
type: 'pie',
259259
object: 'opportunity',
260260
categoryField: 'type',
261261
aggregate: 'count',

0 commit comments

Comments
 (0)