Skip to content

Commit 9d85f1b

Browse files
Copilothotlong
andcommitted
fix: address code review feedback — fix changelog naming and simplify redundant ternary
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> Agent-Logs-Url: https://github.com/objectstack-ai/spec/sessions/ad90f5d5-0180-49f2-9b9b-72bf2792ed93
1 parent 52f30c5 commit 9d85f1b

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

packages/services/service-analytics/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ All notable changes to this package will be documented in this file.
1414
- **P3 — InMemoryStrategy**: Delegates to any registered `IAnalyticsService` (e.g., `MemoryAnalyticsService`)
1515
- `CubeRegistry` for auto-discovery and registration of cubes from manifest definitions and object schema inference
1616
- `AnalyticsServicePlugin` for kernel plugin lifecycle integration
17-
- `queryAggregations()` driver capability probing for strategy selection
17+
- `queryCapabilities()` driver capability probing for strategy selection
1818
- `generateSql()` dry-run SQL generation across all strategies
1919
- Unit tests covering all strategy branches

packages/services/service-analytics/src/strategies/native-sql-strategy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ export class NativeSQLStrategy implements AnalyticsStrategy {
178178
for (const m of query.measures) {
179179
const fieldName = m.includes('.') ? m.split('.')[1] : m;
180180
const measure = cube.measures[fieldName];
181-
fields.push({ name: m, type: measure ? 'number' : 'number' });
181+
fields.push({ name: m, type: 'number' });
182182
}
183183
}
184184
return fields;

0 commit comments

Comments
 (0)