Skip to content

Commit 9e0c059

Browse files
fix: address code review feedback — add spec context comment and improve changelog wording
Agent-Logs-Url: https://github.com/objectstack-ai/spec/sessions/c82941ae-4d59-4c6f-8141-5e25d43599a3 Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
1 parent 30f3c57 commit 9e0c059

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1313
Only `records` is returned, matching the `FindDataResponseSchema` spec. All
1414
downstream consumers (Studio, app-host example, tests) updated to use `records`
1515
exclusively. OData-specific responses (`ODataResponseSchema`) retain `value` per
16-
the OData v4 standard — protocol adaptation should be handled in the HTTP
16+
the OData v4 standard — protocol-to-OData adaptation is handled in the HTTP
1717
dispatch layer.
1818

1919
### Changed

packages/objectql/src/protocol.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,8 @@ export class ObjectStackProtocolImplementation implements ObjectStackProtocol {
481481
}
482482

483483
const records = await this.engine.find(request.object, options);
484+
// Spec: FindDataResponseSchema — only `records` is returned.
485+
// OData `value` adaptation (if needed) is handled in the HTTP dispatch layer.
484486
return {
485487
object: request.object,
486488
records,

0 commit comments

Comments
 (0)