Skip to content

Commit a4a3688

Browse files
Copilothotlong
andcommitted
fix: address code review feedback - consistent terminology and enforce min reload interval
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent e046ed7 commit a4a3688

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

packages/spec/src/kernel/plugin-loading.zod.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,9 +306,9 @@ export const PluginHotReloadSchema = z.object({
306306
* Target environment for hot reload behavior
307307
*/
308308
environment: z.enum([
309-
'development', // Fast reload with relaxed safety (file watchers, no health gates)
309+
'development', // Fast reload with relaxed safety (file watchers, no health validation)
310310
'staging', // Production-like reload with validation but relaxed rollback
311-
'production', // Full safety: health gates, rollback, connection draining
311+
'production', // Full safety: health validation, rollback, connection draining
312312
]).default('development').describe('Target environment controlling safety level'),
313313

314314
/**
@@ -404,7 +404,7 @@ export const PluginHotReloadSchema = z.object({
404404
/**
405405
* Minimum interval between reloads of the same plugin (ms)
406406
*/
407-
minReloadInterval: z.number().int().min(0).default(5000)
407+
minReloadInterval: z.number().int().min(1000).default(5000)
408408
.describe('Cooldown period between reloads of the same plugin'),
409409
}).optional(),
410410
}).describe('Plugin hot reload configuration');

0 commit comments

Comments
 (0)