Skip to content

Commit b8ce2da

Browse files
os-zhuangclaude
andauthored
ci(release): restore blocking live-hotcrm smoke — v2 adoption shipped (hotcrm v2.0.0) (#2730)
Closes the ADR-0090 launch-window advisory period from #2719: hotcrm v2.0.0 adopts the v2 vocabulary (hotcrm#438), so HOTCRM_REF bumps to that tag and the continue-on-error escape hatch is deleted — a red smoke blocks publish again. DO NOT MERGE before the hotcrm v2.0.0 tag exists. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent 216fa9a commit b8ce2da

1 file changed

Lines changed: 6 additions & 17 deletions

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -62,18 +62,6 @@ jobs:
6262
run: bash scripts/build-console.sh
6363

6464
- name: Downstream backward-compat smoke (live hotcrm)
65-
# TEMPORARY (ADR-0090 v2 launch window) — advisory, not blocking.
66-
# ADR-0090 P1 (#2697) removed the sharing recipients `role` /
67-
# `role_and_subordinates` from @objectstack/spec with NO compatibility
68-
# aliases (docs/adr/0090 D3 — a deliberate, launch-window break). The
69-
# latest published hotcrm tag (v1.2.2) still authors those values, so
70-
# this gate necessarily goes red on a break the spec took on purpose,
71-
# and no adopting hotcrm release exists yet to bump HOTCRM_REF to. Keep
72-
# the step running for signal, but don't let it block the v2 publish.
73-
# RESTORE (make blocking again): once hotcrm ships a release adopting
74-
# the v2 recipient vocabulary, bump HOTCRM_REF below to that tag and
75-
# delete this `continue-on-error` line so a red here blocks publish.
76-
continue-on-error: true
7765
# Pre-publish gate (#2035): the about-to-publish @objectstack/spec must
7866
# not break a real third-party consumer pinned to a published release.
7967
# Clones objectstack-ai/hotcrm@${HOTCRM_REF}, installs it (published
@@ -82,11 +70,12 @@ jobs:
8270
# The deterministic in-repo floor is @objectstack/downstream-contract;
8371
# this is the live ceiling.
8472
env:
85-
# v1.2.1: hotcrm dropped the ObjectSchema `detail` block removed by
86-
# ADR-0085 (hotcrm#423) — the intended break, explicitly digested
87-
# downstream. Bump this ref whenever a deliberate spec surface
88-
# removal ships a matching hotcrm release.
89-
HOTCRM_REF: v1.2.2
73+
# v2.0.0: hotcrm adopted the ADR-0090 Permission Model v2 vocabulary
74+
# (role→position recipients, profiles removed, explicit OWD —
75+
# hotcrm#438), closing the launch-window advisory period from #2719.
76+
# Bump this ref whenever a deliberate spec surface removal ships a
77+
# matching hotcrm release.
78+
HOTCRM_REF: v2.0.0
9079
run: bash scripts/downstream-smoke.sh
9180

9281
- name: Create Release Pull Request or Publish to npm

0 commit comments

Comments
 (0)