Refactor AppManifestPlugin to support both direct and nested manifest structures

Author: hotlong

packages/plugin-hono-server/src/index.ts

@@ -1,104 +1 @@
-import { serve } from '@hono/node-server';
-import { serveStatic } from '@hono/node-server/serve-static';
-import { Hono } from 'hono';
-import { cors } from 'hono/cors';
-import { logger } from 'hono/logger';
-import { ObjectStackRuntimeProtocol } from '@objectstack/runtime';
-import { RuntimePlugin, IKernel } from '@objectstack/types';
-
-export interface HonoServerOptions {
-  port?: number;
-  staticRoot?: string;
-  cors?: boolean;
-  logger?: boolean;
-}
-
-/**
- * Hono Server Runtime Plugin
- * 
- * Exposes the ObjectStack Kernel via standard HTTP Protocol using Hono.
- * Can be used for Production (Standalone) or Development.
- */
-export class HonoServerPlugin implements RuntimePlugin {
-  name = 'com.objectstack.server.hono';
-  
-  private options: HonoServerOptions;
-
-  constructor(options: HonoServerOptions = {}) {
-    this.options = { 
-        port: 3000, 
-        cors: true,
-        logger: true,
-        ...options 
-    };
-  }
-
-  async onStart(ctx: { engine: IKernel }) {
-    const app = new Hono();
-    // TODO: Protocol needs access to actual Kernel instance or we make Protocol an interface too
-    const protocol = new ObjectStackRuntimeProtocol(ctx.engine as any);
-
-    // 1. Middlewares
-    if (this.options.logger) app.use('*', logger());
-    if (this.options.cors) app.use('*', cors());
-
-    // 2. Wiring Protocol (Automatic)
-    // Discovery
-    app.get('/api/v1', (c) => c.json(protocol.getDiscovery()));
-    
-    // Meta Protocol
-    app.get('/api/v1/meta', (c) => c.json(protocol.getMetaTypes()));
-    app.get('/api/v1/meta/:type', (c) => c.json(protocol.getMetaItems(c.req.param('type'))));
-    app.get('/api/v1/meta/:type/:name', (c) => {
-        try {
-            return c.json(protocol.getMetaItem(c.req.param('type'), c.req.param('name')));
-        } catch(e:any) {
-            return c.json({error: e.message}, 404);
-        }
-    });
-    
-    // Data Protocol
-    app.get('/api/v1/data/:object', async (c) => {
-        try { return c.json(await protocol.findData(c.req.param('object'), c.req.query())); } 
-        catch(e:any) { return c.json({error:e.message}, 400); }
-    });
-    app.get('/api/v1/data/:object/:id', async (c) => {
-        try { return c.json(await protocol.getData(c.req.param('object'), c.req.param('id'))); }
-        catch(e:any) { return c.json({error:e.message}, 404); }
-    });
-    app.post('/api/v1/data/:object', async (c) => {
-        try { return c.json(await protocol.createData(c.req.param('object'), await c.req.json()), 201); }
-        catch(e:any) { return c.json({error:e.message}, 400); }
-    });
-    app.patch('/api/v1/data/:object/:id', async (c) => {
-        try { return c.json(await protocol.updateData(c.req.param('object'), c.req.param('id'), await c.req.json())); }
-        catch(e:any) { return c.json({error:e.message}, 400); }
-    });
-    app.delete('/api/v1/data/:object/:id', async (c) => {
-        try { return c.json(await protocol.deleteData(c.req.param('object'), c.req.param('id'))); }
-        catch(e:any) { return c.json({error:e.message}, 400); }
-    });
-
-    // UI Protocol
-    // @ts-ignore
-    app.get('/api/v1/ui/view/:object', (c) => {
-        try { 
-            const viewType = (c.req.query('type') as 'list' | 'form') || 'list';
-            return c.json(protocol.getUiView(c.req.param('object'), viewType)); 
-        }
-        catch(e:any) { return c.json({error:e.message}, 404); }
-    });
-
-    // 3. Static Files (Optional)
-    if (this.options.staticRoot) {
-        app.get('/', serveStatic({ root: this.options.staticRoot, path: 'index.html' }));
-        app.get('/*', serveStatic({ root: this.options.staticRoot }));
-    }
-
-    console.log('');
-    console.log(`🌍 ObjectStack Server (Hono) running at: http://localhost:${this.options.port}`);
-    console.log('');
-    
-    serve({ fetch: app.fetch, port: this.options.port });
-  }
-}
+export * from './hono-plugin';

packages/runtime/src/app-manifest-plugin.ts

@@ -23,15 +23,19 @@ export class AppManifestPlugin implements Plugin {
 
     constructor(manifest: any) {
         this.manifest = manifest;
-        this.name = manifest.id || manifest.name || 'unnamed-app';
-        this.version = manifest.version;
+        // Support both direct manifest (legacy) and Stack Definition (nested manifest)
+        const sys = manifest.manifest || manifest;
+        this.name = sys.id || sys.name || 'unnamed-app';
+        this.version = sys.version;
     }
 
     async init(ctx: PluginContext) {
-        ctx.logger.log(`[AppManifestPlugin] Loading App Manifest: ${this.manifest.id || this.manifest.name}`);
+        // Support both direct manifest (legacy) and Stack Definition (nested manifest)
+        const sys = this.manifest.manifest || this.manifest;
+        ctx.logger.log(`[AppManifestPlugin] Loading App Manifest: ${sys.id || sys.name}`);
 
         // Register the app/plugin in the schema registry
-        SchemaRegistry.registerPlugin(this.manifest);
+        SchemaRegistry.registerPlugin(sys);
 
         // Register all objects defined in the manifest
         if (this.manifest.objects) {
@@ -45,7 +49,8 @@ export class AppManifestPlugin implements Plugin {
     async start(ctx: PluginContext) {
         // Seed data if provided
         if (this.manifest.data && Array.isArray(this.manifest.data)) {
-            ctx.logger.log(`[AppManifestPlugin] Seeding data for ${this.manifest.name || this.manifest.id}...`);
+            const sys = this.manifest.manifest || this.manifest;
+            ctx.logger.log(`[AppManifestPlugin] Seeding data for ${sys.name || sys.id}...`);
 
             const objectql = ctx.getService<ObjectQL>('objectql');