Commit de46ea1
docs(approvals): drop duplicate role-vs-position callout (unbreak role-word ratchet)
The ESLint job's "Reserved-word (role) docs ratchet" step has been red on main
since 25a19be, which took approvals.mdx from 5 -> 9 role-word occurrences.
Every open PR inherits the red check.
The occurrences are NOT ADR-0090 D3 drift and cannot be reworded away: `role`
is a real, shipping approver type (spec/src/automation/approval.zod.ts:14) that
resolves against better-auth's org-membership tier (`sys_member.role`), which
D3 names as its single documented exception ("third-party schema we do not
own"). Writing `position` in these spots would make the docs wrong -- telling
the two apart is the entire point of the passage, and of the
`approval-role-not-membership-tier` lint rule.
What the ratchet did catch is real redundancy: the new callout under "The
request opens, the run pauses" restates the callout ~75 lines above it, which
says the same thing and more (it names the lint rule). Removed the duplicate.
That leaves `role:<r>` in the approverId filter list -- a genuine new fact at
the same sanctioned boundary (spec/src/contracts/approval-service.ts:231).
Rather than delete a true API detail to satisfy a counter, the surviving
callout is tightened: it stated role-the-approver-type twice ("The `role`
approver type ..." and "authored as `type: 'role'`"), now once. That frees the
slot, so the file lands back at exactly 5.
Baseline deliberately NOT bumped -- a high-water mark that only ratchets down
is the point of the gate.
Verified: node scripts/check-role-word.mjs -> OK (exit 0); pnpm lint -> exit 0.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 5f05de2 commit de46ea1
1 file changed
Lines changed: 4 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | 135 | | |
143 | 136 | | |
144 | 137 | | |
| |||
0 commit comments