Skip to content

Commit ee32099

Browse files
Claudehotlong
andauthored
fix: address PR review feedback - add type: module, fix .vercelignore, remove unused .npmrc
- Add "type": "module" to package.json for ESM compatibility (Vercel handler is ESM) - Fix .vercelignore to not exclude build dependencies (server/, scripts/bundle-api.mjs) - Remove app-specific .npmrc (not honored when install runs from monorepo root) These changes address feedback from @copilot-pull-request-reviewer: 1. ESM files require "type": "module" in package.json (matches apps/studio pattern) 2. Build script needs access to server/ and scripts/ during Vercel build 3. .npmrc node-linker=hoisted is unnecessary with Turso remote mode (no native modules) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent 6c106d1 commit ee32099

File tree

3 files changed

+2
-12
lines changed

3 files changed

+2
-12
lines changed

examples/app-host/.npmrc

Lines changed: 0 additions & 3 deletions
This file was deleted.

examples/app-host/.vercelignore

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,8 @@ test/
77
*.test.ts
88
*.spec.ts
99

10-
# Ignore development files
10+
# Ignore development-only files that are not required by the Vercel build
1111
debug-registry.ts
12-
src/
13-
14-
# Ignore source files (only need the bundle)
15-
server/
16-
scripts/bundle-api.mjs
17-
18-
# Ignore metadata (using in-memory driver)
19-
metadata/
2012

2113
# Keep only the bundled API handler
2214
!api/_handler.js

examples/app-host/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"name": "@example/app-host",
33
"version": "4.0.3",
44
"license": "Apache-2.0",
5+
"type": "module",
56
"private": true,
67
"scripts": {
78
"dev": "objectstack serve --dev",

0 commit comments

Comments
 (0)