Skip to content

Commit f2c8f6e

Browse files
committed
refactor: remove view storage functionality and related schemas
- Deleted view storage implementation from ObjectStackProtocolImplementation. - Removed JSON schema files for view-related requests and responses. - Updated protocol.zod.ts to eliminate view storage schemas and related types. - Removed view storage tests and associated Zod schemas.
1 parent 99ffe47 commit f2c8f6e

23 files changed

+3
-1283
lines changed

content/docs/references/api/index.mdx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ This section contains all protocol schemas for the api layer of ObjectStack.
2020
<Card href="./realtime" title="Realtime" description="Source: packages/spec/src/api/realtime.zod.ts" />
2121
<Card href="./rest-server" title="Rest Server" description="Source: packages/spec/src/api/rest-server.zod.ts" />
2222
<Card href="./router" title="Router" description="Source: packages/spec/src/api/router.zod.ts" />
23-
<Card href="./view-storage" title="View Storage" description="Source: packages/spec/src/api/view-storage.zod.ts" />
2423
<Card href="./websocket" title="Websocket" description="Source: packages/spec/src/api/websocket.zod.ts" />
2524
</Cards>
2625

content/docs/references/api/meta.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
"realtime",
1414
"rest-server",
1515
"router",
16-
"view-storage",
1716
"websocket"
1817
]
1918
}

content/docs/references/api/protocol.mdx

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ description: Protocol protocol schemas
1212
## TypeScript Usage
1313

1414
```typescript
15-
import { BatchDataRequestSchema, BatchDataResponseSchema, CreateDataRequestSchema, CreateDataResponseSchema, CreateManyDataRequestSchema, CreateManyDataResponseSchema, DeleteDataRequestSchema, DeleteDataResponseSchema, DeleteManyDataRequestSchema, DeleteManyDataResponseSchema, DeleteViewRequestSchema, DeleteViewResponseSchema, FindDataRequestSchema, FindDataResponseSchema, GetDataRequestSchema, GetDataResponseSchema, GetDiscoveryRequestSchema, GetDiscoveryResponseSchema, GetMetaItemCachedRequestSchema, GetMetaItemCachedResponseSchema, GetMetaItemRequestSchema, GetMetaItemResponseSchema, GetMetaItemsRequestSchema, GetMetaItemsResponseSchema, GetMetaTypesRequestSchema, GetMetaTypesResponseSchema, GetUiViewRequestSchema, GetUiViewResponseSchema, GetViewRequestSchema, GetViewResponseSchema, ObjectStackProtocolSchema, UpdateDataRequestSchema, UpdateDataResponseSchema, UpdateManyDataRequestSchema, UpdateManyDataResponseSchema } from '@objectstack/spec/api';
16-
import type { BatchDataRequest, BatchDataResponse, CreateDataRequest, CreateDataResponse, CreateManyDataRequest, CreateManyDataResponse, DeleteDataRequest, DeleteDataResponse, DeleteManyDataRequest, DeleteManyDataResponse, DeleteViewRequest, DeleteViewResponse, FindDataRequest, FindDataResponse, GetDataRequest, GetDataResponse, GetDiscoveryRequest, GetDiscoveryResponse, GetMetaItemCachedRequest, GetMetaItemCachedResponse, GetMetaItemRequest, GetMetaItemResponse, GetMetaItemsRequest, GetMetaItemsResponse, GetMetaTypesRequest, GetMetaTypesResponse, GetUiViewRequest, GetUiViewResponse, GetViewRequest, GetViewResponse, ObjectStackProtocol, UpdateDataRequest, UpdateDataResponse, UpdateManyDataRequest, UpdateManyDataResponse } from '@objectstack/spec/api';
15+
import { BatchDataRequestSchema, BatchDataResponseSchema, CreateDataRequestSchema, CreateDataResponseSchema, CreateManyDataRequestSchema, CreateManyDataResponseSchema, DeleteDataRequestSchema, DeleteDataResponseSchema, DeleteManyDataRequestSchema, DeleteManyDataResponseSchema, FindDataRequestSchema, FindDataResponseSchema, GetDataRequestSchema, GetDataResponseSchema, GetDiscoveryRequestSchema, GetDiscoveryResponseSchema, GetMetaItemCachedRequestSchema, GetMetaItemCachedResponseSchema, GetMetaItemRequestSchema, GetMetaItemResponseSchema, GetMetaItemsRequestSchema, GetMetaItemsResponseSchema, GetMetaTypesRequestSchema, GetMetaTypesResponseSchema, GetUiViewRequestSchema, GetUiViewResponseSchema, ObjectStackProtocolSchema, UpdateDataRequestSchema, UpdateDataResponseSchema, UpdateManyDataRequestSchema, UpdateManyDataResponseSchema } from '@objectstack/spec/api';
16+
import type { BatchDataRequest, BatchDataResponse, CreateDataRequest, CreateDataResponse, CreateManyDataRequest, CreateManyDataResponse, DeleteDataRequest, DeleteDataResponse, DeleteManyDataRequest, DeleteManyDataResponse, FindDataRequest, FindDataResponse, GetDataRequest, GetDataResponse, GetDiscoveryRequest, GetDiscoveryResponse, GetMetaItemCachedRequest, GetMetaItemCachedResponse, GetMetaItemRequest, GetMetaItemResponse, GetMetaItemsRequest, GetMetaItemsResponse, GetMetaTypesRequest, GetMetaTypesResponse, GetUiViewRequest, GetUiViewResponse, ObjectStackProtocol, UpdateDataRequest, UpdateDataResponse, UpdateManyDataRequest, UpdateManyDataResponse } from '@objectstack/spec/api';
1717

1818
// Validate data
1919
const result = BatchDataRequestSchema.parse(data);
@@ -61,14 +61,6 @@ const result = BatchDataRequestSchema.parse(data);
6161

6262
---
6363

64-
## DeleteViewRequest
65-
66-
---
67-
68-
## DeleteViewResponse
69-
70-
---
71-
7264
## FindDataRequest
7365

7466
---
@@ -133,14 +125,6 @@ const result = BatchDataRequestSchema.parse(data);
133125

134126
---
135127

136-
## GetViewRequest
137-
138-
---
139-
140-
## GetViewResponse
141-
142-
---
143-
144128
## ObjectStackProtocol
145129

146130
---

content/docs/references/api/view-storage.mdx

Lines changed: 0 additions & 61 deletions
This file was deleted.

packages/objectql/src/protocol.ts

Lines changed: 0 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,6 @@ import type {
77
DeleteManyDataRequest
88
} from '@objectstack/spec/api';
99
import type { MetadataCacheRequest, MetadataCacheResponse } from '@objectstack/spec/api';
10-
import type {
11-
CreateViewRequest,
12-
UpdateViewRequest,
13-
ListViewsRequest,
14-
ViewResponse,
15-
ListViewsResponse,
16-
SavedView
17-
} from '@objectstack/spec/api';
1810

1911
// We import SchemaRegistry directly since this class lives in the same package
2012
import { SchemaRegistry } from './registry.js';
@@ -35,7 +27,6 @@ function simpleHash(str: string): string {
3527

3628
export class ObjectStackProtocolImplementation implements ObjectStackProtocol {
3729
private engine: IDataEngine;
38-
private viewStorage: Map<string, SavedView> = new Map();
3930

4031
constructor(engine: IDataEngine) {
4132
this.engine = engine;
@@ -245,62 +236,4 @@ export class ObjectStackProtocolImplementation implements ObjectStackProtocol {
245236
});
246237
}
247238

248-
// ==========================================
249-
// View Storage (Mock Implementation for now)
250-
// ==========================================
251-
252-
async createView(request: CreateViewRequest): Promise<ViewResponse> {
253-
const id = Math.random().toString(36).substring(7);
254-
// Cast to unknown then SavedView to bypass strict type checks for the mock
255-
const view: SavedView = {
256-
id,
257-
...request,
258-
createdAt: new Date().toISOString(),
259-
updatedAt: new Date().toISOString(),
260-
createdBy: 'system',
261-
updatedBy: 'system'
262-
} as unknown as SavedView;
263-
264-
this.viewStorage.set(id, view);
265-
return { success: true, data: view };
266-
}
267-
268-
async getView(request: { id: string }): Promise<ViewResponse> {
269-
const view = this.viewStorage.get(request.id);
270-
if (!view) throw new Error(`View ${request.id} not found`);
271-
return { success: true, data: view };
272-
}
273-
274-
async listViews(request: ListViewsRequest): Promise<ListViewsResponse> {
275-
const views = Array.from(this.viewStorage.values())
276-
.filter(v => !request?.object || v.object === request.object);
277-
278-
return {
279-
success: true,
280-
data: views,
281-
pagination: {
282-
total: views.length,
283-
limit: request.limit || 50,
284-
offset: request.offset || 0,
285-
hasMore: false
286-
}
287-
};
288-
}
289-
290-
async updateView(request: UpdateViewRequest): Promise<ViewResponse> {
291-
const view = this.viewStorage.get(request.id);
292-
if (!view) throw new Error(`View ${request.id} not found`);
293-
294-
const { id, ...updates } = request;
295-
// Cast to unknown then SavedView to bypass strict type checks for the mock
296-
const updated = { ...view, ...updates, updatedAt: new Date().toISOString() } as unknown as SavedView;
297-
this.viewStorage.set(request.id, updated);
298-
return { success: true, data: updated };
299-
}
300-
301-
async deleteView(request: { id: string }): Promise<{ success: boolean, object: string, id: string }> {
302-
const deleted = this.viewStorage.delete(request.id);
303-
if (!deleted) throw new Error(`View ${request.id} not found`);
304-
return { success: true, object: 'view', id: request.id };
305-
}
306239
}

packages/spec/json-schema/api/CreateViewRequest.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/spec/json-schema/api/DeleteViewRequest.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/spec/json-schema/api/DeleteViewResponse.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/spec/json-schema/api/GetViewRequest.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/spec/json-schema/api/GetViewResponse.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)