Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue in action step execution
Fix test data to match evolved schemas
Jan 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes test failures caused by schema updates in the ObjectStack spec package. The changes align test files with updated Zod schema definitions for sharing rules, plugin context, and driver interfaces.
Changes:
- Updated sharing rule tests to match the new discriminated union schema structure (owner vs criteria types, structured sharedWith/ownedBy objects, and 'condition' instead of 'criteria')
- Added missing 'drivers' field to all plugin context mock objects in tests
- Added missing 'findStream' and 'upsert' methods to all driver interface mock objects in tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/spec/src/permission/sharing.test.ts | Updated all test cases to align with the new SharingRuleSchema structure, including proper type restrictions ('owner', 'criteria'), level support ('full' added), structured sharedWith/ownedBy objects, and field renaming (criteria → condition) |
| packages/spec/src/kernel/plugin.test.ts | Added the drivers.register field to all plugin context mock objects to match the PluginContextSchema definition |
| packages/spec/src/driver/driver.test.ts | Added findStream and upsert methods to all driver interface mock objects to match the DriverInterfaceSchema definition |
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
…and test expectations Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were failing because schemas evolved but test data wasn't updated. Three files affected:
sharing.test.ts
typefield and structuredsharedWithobjectdriver.test.ts
findStream,upsertplugin.test.ts
driversfield to all PluginContext mocksAll 64 tests in affected files now pass.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.