feat(adr-0006)!: Phase 4 — remove cloud plugins from framework runtime + CLI#1723
Merged
Merged
Conversation
…e + CLI
BREAKING CHANGE (ADR-0006 Phase 4 / cloud ADR-0007 ⑤): deletes the
framework's deprecated duplicate cloud plugins and the CLI's auto-inject
of them.
Removed from @objectstack/runtime (public API):
- MarketplaceProxyPlugin (+Config), MarketplaceInstallLocalPlugin
(+Config), RuntimeConfigPlugin (+Config), DEFAULT_CLOUD_URL,
resolveCloudUrl — src/cloud/{marketplace-proxy-plugin,
marketplace-install-local-plugin,marketplace-public-url,
runtime-config-plugin,cloud-url}.ts + their tests.
- KEPT: cloud/environment-registry.ts (EnvironmentDriverRegistry /
KernelManager interface contracts, D3) and the KernelResolver seam —
both converge in Phase 5.
Removed from @objectstack/cli serve: the 5b/5b-ii auto-inject blocks.
A vanilla `objectstack dev` no longer mounts marketplace browse/install
or /api/v1/runtime/config — those are cloud-distribution features
(@objectstack/objectos-runtime), wired explicitly by hosts (see the cloud
repo's apps/objectos-ee config). The Console SPA falls back to defaults
when runtime/config is absent. CLI's own utils/cloud-config.ts
DEFAULT_CLOUD_URL (plugin publish / cloud login) is unrelated and stays.
Canonical copies: cloud packages/objectos-runtime (already ahead of the
deleted ones — ADR-0036 seeds rename). These were @deprecated since
ADR-0006 Phase 1 (#1717); the cloud apps stopped booting through CLI
cloud-serve in cloud#214/#215 (Phase 3).
Validation: runtime build + 370 tests, CLI build (tsc) + 240 tests; cloud
repo against this checkout: boot-smoke ALL GREEN + typecheck clean on
objectos-runtime / objectos / objectos-ee / cloud.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-0006 Phase 4 — 框架 CLI 解耦 + 删云插件 (breaking; = cloud ADR-0007 ⑤完成)
Deletes the framework's deprecated duplicate cloud plugins (marked
@deprecatedin #1717) and the CLI serve auto-inject that load-beared them. Cloud apps stopped booting through CLI cloud-serve in cloud#214/#215 (Phase 3), so nothing in the cloud product depends on these anymore.Removed (public API — breaking)
MarketplaceProxyPlugin,MarketplaceInstallLocalPlugin,RuntimeConfigPlugin(+ their*Configtypes),DEFAULT_CLOUD_URL,resolveCloudUrl; theruntime/src/cloud/implementation files + tests; CLI serve's 5b/5b-ii auto-inject blocks.Kept (deliberately)
cloud/environment-registry.ts—EnvironmentDriverRegistry/KernelManagercontracts (D3) + theKernelResolverseam (Phase 2). Both converge in Phase 5.utils/console.ts(Console static-serve — generic UI hosting, used by the cloud node bootstrap per D-CONSOLE Option 1) andutils/cloud-config.ts(its own unrelatedDEFAULT_CLOUD_URLforplugin publish/cloud login).Behavior change for vanilla OSS users (per ADR-0004 boundary)
objectstack devno longer mounts marketplace browse/install-local or/api/v1/runtime/config. Hosts that want them wire the canonical cloud copies explicitly (see cloudapps/objectos-ee's config). Console SPA degrades gracefully (defaults on 404).Validation
.framework-shabump lands as the paired cloud PR immediately after this merges (deploy_flow).🤖 Generated with Claude Code