fix(spec): align reportForm with the 9.0 dataset-bound ReportSchema (ADR-0021)#1730
Merged
Conversation
…ADR-0021) The authoring form still declared the pre-9.0 query-form fields (objectName / columns / groupingsDown / groupingsAcross / filter) that the single-form cutover removed from ReportSchema — so spec-driven editors rendered controls whose output the schema strips at parse time (and `filter` had been renamed `runtimeFilter`). Declare the dataset-bound shape instead: a Dataset binding section with `dataset` (new `ref:dataset` widget hint) + `values` / `rows` string-tag selectors, `runtimeFilter` under Filter & chart, and joined blocks unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
size/s
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reportForm(the canonical Report authoring FormView) still declared the pre-9.0 query-form fields —objectName/columns/groupingsDown/groupingsAcross/filter— that the ADR-0021 single-form cutover removed fromReportSchema. Spec-driven editors (e.g. objectui's ReportDefaultInspector, which rendersreportFormverbatim) therefore offered controls whose output the 9.0 schema strips at parse time, andfilterhad been renamedruntimeFilter.This aligns the form with the schema:
objectNamejoined):datasetwith a newref:datasetwidget hint (mirroring the existingref:objectconvention), plusvalues/rowsasstring-tagsfilter→runtimeFilter(jsonwidget)Changeset: patch on
@objectstack/spec(fixed group).Test plan
pnpm buildin packages/specpnpm testin packages/spec — 6527 passedDownstream: objectui will consume this via its dataset-native report editor (PR to follow there).
🤖 Generated with Claude Code