feat(service-ai): ADR-0040 — unify the platform assistant (data + authoring registers)#1735
Merged
Merged
Conversation
…horing registers) The default data_chat agent becomes THE platform assistant: - skills: + metadata_authoring + solution_design (registered by the cloud AI Studio plugin; deployments without it degrade gracefully to data-only — the skill registry ignores unresolved names). - instructions: intent preamble — classify build/change vs data intent FIRST, apply that register's discipline, never mix registers or narrate failures. - persona: label 'Assistant', role 'Business Application Assistant'. - model: temperature 0.2 (authoring determinism wins). - guardrails: blocklist union MINUS alter_schema/drop_table (the build register IS schema work, and it is already draft-gated per ADR-0033); 60s execution budget for whole-app builds. - planning: react ×10 with replan (builds take more steps than answers). Motivation (staging 2026-06-11): the data-only persona accepted a whole-app build — tools are registry-global — without the authoring disciplines, hand- rolled the schema, collided with leftovers, and narrated its debugging to a business user. ADR-0040: the end user never picks an agent; one assistant carries both registers and the skills system does per-intent behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the agent half of ADR-0040:
data_chatbecomes the platform assistant.metadata_authoring,solution_design(cloud AI Studio plugin registers them; without it the references don't resolve and the assistant gracefully degrades to data-only).alter_schema/drop_table— the build register IS schema work and is already draft-gated (ADR-0033); keepsdelete_records,drop_database,raw_sql,system_tables.Tests updated to the new persona (role/label/instructions/temperature/skills). service-ai 334/335 — the 1 failure (
embedder binding) fails identically on unmodified origin/main in a fresh worktree (env-dependent optional provider; user's built checkout passes it 97/97).Note: agent metadata registration is exists-gated — durable envs keep the old persona until their agent record refreshes; ephemeral staging kernels pick this up on next boot (known limitation, same as skills).
objectui half (picker removal) lands separately; the ADR-0038 L5 golden-prompt suite guards both registers post-unification.
🤖 Generated with Claude Code