feat(approvals): thread interactions — reassign, remind, request-info, comment + SLA & step progress#1740
Merged
Merged
Conversation
…, comment + SLA & step progress Closes the collaboration gap vs mainstream approval centers (ServiceNow / SAP Fiori My Inbox / DingTalk-Feishu). None of these move the flow; they operate on approver slots or the audit thread: - reassign(): a pending approver hands their slot to someone else (audit-first ordering mirrors decideNode), with the new approver notified via the optional `messaging` service. - remind(): submitter nudge to every pending approver, throttled to one per 4h per request (THROTTLED → HTTP 429). - requestInfo(): approver sends the request back to the submitter for more material — request stays pending, submitter notified. - comment(): free-form thread reply (submitter or pending approver), notifying the other side. - `sys_approval_action.action` enum gains reassign/remind/request_info/ comment (kept in sync with the new ApprovalActionKind contract type). - Rows expose `sla_due_at` (created_at + escalation.timeoutHours from the node config — display-only; automatic escalation still needs a scheduler pass) and single reads attach `flow_steps` (the owning flow's approval trunk with done/current/upcoming states) via the automation surface's getFlow(). - REST: POST reassign / remind / request-info / comment routes with the shared error mapping (+THROTTLED→429); messaging wired in the plugin when installed, degrading to audit-only without it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
added a commit
that referenced
this pull request
Jun 11, 2026
…s-thread chore: changeset for approvals thread interactions (#1740)
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of the approvals roadmap (after #1728/#1737): the collaboration layer that mainstream approval centers (ServiceNow, SAP Fiori My Inbox, DingTalk/Feishu) treat as table stakes. None of these move the flow — they operate on approver slots or the audit thread.
reassign()— a pending approver hands their slot to someone else. Audit-first write ordering (mirrorsdecideNode) so a failed audit can never leave a moved slot without a trail; the new approver is notified via the optionalmessagingservice.remind()— submitter nudge to every pending approver, throttled to one per 4 h per request (THROTTLED→ HTTP 429).requestInfo()— approver sends the request back for more material; the request stays pending, submitter notified.comment()— free-form thread reply (submitter or pending approver), notifying the other side.sys_approval_action.actionenum gains the four new kinds (synced with the newApprovalActionKindcontract type — the first e2e run caught the enum validation rejecting them).sla_due_at(created_at + escalation.timeoutHoursfrom the node config; display-only — automatic escalation needs a scheduler pass, called out in the JSDoc) and single reads attachflow_steps(the owning flow's approval trunk with done/current/upcoming states) via the automation surface'sgetFlow().POST …/reassign|remind|request-info|commentwith the shared error mapping; messaging wired in the plugin when installed, degrading to audit-only without it.Test plan
actor_name;flow_steps= Manager Review (current) → Executive Review (upcoming);sla_due_atpresent only when the node declares an SLA ✅🤖 Generated with Claude Code