fix(spec): object.tenancy.tenantField is live (sql-driver), not dead — deletion paused#1958
Merged
Merged
Conversation
…ing), not dead
5th audit reversal found while attempting the 'obvious safe delete' of tenancy.*
(assumed obsolete under DB-per-tenant). In fact the platform ALSO does row-level
org-scoping (plugin-org-scoping), and driver-sql resolves tenant scope from
obj.tenancy.{enabled,tenantField} — so tenantField is LIVE. Reclassified; flagged
strategy/crossTenantAccess to verify before any change. agent.tenantId confirmed
dead (no reader in service-ai or objectui AgentPreview).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 89 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
added a commit
that referenced
this pull request
Jun 24, 2026
feat(studio): surface flow validation errors inline on the canvas (#1958) objectui@4c2f910c4e35d09f333adcdf62734d1d8280674e
This was referenced Jun 24, 2026
os-zhuang
added a commit
that referenced
this pull request
Jun 24, 2026
#2279) `objectstack compile` (lint-flow-patterns) now warns on two send-back-for- revision shapes an AI authoring an approval flow gets wrong: - Dead-end revise: an approval with a `revise` out-edge but no path looping back to it — a valid DAG that `registerFlow` ACCEPTS, yet the submitter reworks the record with nowhere to resubmit. The linter is the only place that catches this. - Un-declared revise loop: the loop returns to the approval but the closing edge isn't `type: 'back'`, so `registerFlow` rejects it as an un-declared cycle — the lint fires at compile time with the specific fix. Also flags `maxRevisions: 0` alongside a `revise` edge (send-back disabled). Advisory only; never fails the build. Mirrors the client-side rule shipped in objectui (#1958). Refs #2274, #1770 (ADR-0044). Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5th audit reversal: driver-sql resolves tenant scope from obj.tenancy.{enabled,tenantField} (plugin-org-scoping row-level path) — tenancy.tenantField is LIVE, not inert. agent.tenantId confirmed dead. Autonomous deletion of 'dead' props is NOT safe (5 reversals + a wrong DB-per-tenant assumption); deletion paused pending an exhaustive cross-repo+cross-plugin re-audit. Gate green.
🤖 Generated with Claude Code