chore(spec): drop the dead agent memory.shortTerm config (ADR-0013 D3, cloud#339)#2094
Merged
Merged
Conversation
…D3, cloud#339)
`memory.shortTerm` ({maxMessages, maxTokens}) declared a working-memory window
that NOTHING in the runtime ever consumed — a config that lies. Per cloud
ADR-0013 D3, cross-turn grounding is done by tools reading live state and the
context budget is governed by the per-request token guardrail, not by this
field. The only place it was set was data-chat-agent's definition (also dead).
- Remove `shortTerm` from the agent `memory` zod schema (keeping `longTerm` /
`reflectionInterval` — forward-looking, off-by-default, not misleading).
- Remove the dead `memory.shortTerm` declaration from data-chat-agent.
- Update the memory-config spec test accordingly.
No runtime behavior change (nothing read it). Public API surface unchanged
(the gate tracks export names, not zod field internals); spec agent tests 45/45.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 91 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the agent
memory.shortTermconfig ({maxMessages, maxTokens}) — a schema field that declared a working-memory window nothing in the runtime ever consumed. Per cloud ADR-0013 D3 ("stop declaring an unwired memory strategy"): cross-turn grounding is done by tools reading live state, and the context budget is governed by the per-request token guardrail — not by this field. It was a config that lies.Changes
packages/spec/src/ai/agent.zod.ts— removeshortTermfrom the agentmemoryschema. KeptlongTerm(off by default) andreflectionInterval— those are forward-looking/optional, not actively misleading.packages/services/service-ai/src/agents/data-chat-agent.ts— remove the deadmemory.shortTermdeclaration (its only set site).packages/spec/src/ai/agent.test.ts— update the memory-config test to the remaining fields.Safety
memory.shortTerm(onlyagent.model.maxTokensis consumed). The sole set site (data-chat-agent) is removed.pnpm --filter @objectstack/spec check:api-surface✓ (the gate tracks exported names/kinds; a zod object's internal field is not a public export name).Relates to cloud#339 / cloud ADR-0013 D3. The
sys_audit_logactor-attribution half (cloud#340) is a separate, larger security/audit-path change and will come in its own PR.🤖 Generated with Claude Code