test(mcp): SKILL.md ↔ native tool-surface drift guard (#2714)#2718
Merged
Conversation
Asserts every tool registered on the HTTP MCP surface appears in the generated SKILL.md, deriving the surface from a real tools/list round-trip rather than a name list. Red-proven: stripping run_action from skill.ts fails with a pointed message. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 9 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2715 (#2714 Phase 0): make the fixed gap structurally unrepeatable.
The 7-of-9 gap happened because
skill.tswas written against the CRUD set after the action tools (#2307) had already shipped — nothing connected the two. This guard derives the registered tool surface from a realtools/listround-trip (MCPServerRuntime+ full data+action bridge, the same harness asmcp-action-tools.test.ts) and asserts every name appears inrenderSkillMarkdown(). No hand-maintained name list: adding a tool tomcp-http-tools.tswithout teaching the skill turns the suite red with a pointed message naming the missing tool.Red-proven: temporarily stripping
run_actionfromskill.tsfails withtools registered but missing from SKILL.md — update packages/mcp/src/skill.ts: run_action.Includes a sanity floor (
>= 9tools seen) so a broken harness can't pass vacuously. Test-only; no runtime change. 64/64 pass.Refs #2714, #2715.
🤖 Generated with Claude Code